From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753411AbaI2JzJ (ORCPT ); Mon, 29 Sep 2014 05:55:09 -0400 Received: from top.free-electrons.com ([176.31.233.9]:45423 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751146AbaI2JzF (ORCPT ); Mon, 29 Sep 2014 05:55:05 -0400 Date: Mon, 29 Sep 2014 11:53:44 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel , devicetree , linux-kernel , Shuge , Meng Zhang , ctl , Gregory CLEMENT Subject: Re: [PATCH v2 4/7] ARM: dts: sun9i: Add A80 Optimus Board support Message-ID: <20140929095344.GE4388@lukather> References: <1411570141-29960-1-git-send-email-wens@csie.org> <1411570141-29960-5-git-send-email-wens@csie.org> <20140925133427.GI15315@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Wb5NtZlyOqqy58h0" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Wb5NtZlyOqqy58h0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 27, 2014 at 09:10:48PM +0800, Chen-Yu Tsai wrote: > On Thu, Sep 25, 2014 at 9:34 PM, Maxime Ripard > wrote: > > On Wed, Sep 24, 2014 at 10:48:58PM +0800, Chen-Yu Tsai wrote: > >> The A80 Optimus Board is was launched with the Allwinner A80 SoC. > >> It was jointly developed by Allwinner and Merrii. > >> > >> This board has a UART port, a JTAG connector, USB host ports, a USB > >> 3.0 OTG connector, an HDMI output, a micro SD slot, 8G NAND flash, > >> 4G DRAM, a camera sensor interface, a WiFi/BT combo chip, a headphone > >> jack, IR receiver, and additional GPIO headers. > >> > >> This patch adds only basic support. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> arch/arm/boot/dts/Makefile | 2 + > >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 66 ++++++++++++++++++++++++= +++++++++ > >> 2 files changed, 68 insertions(+) > >> create mode 100644 arch/arm/boot/dts/sun9i-a80-optimus.dts > >> > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > >> index 2f42b18..098f319 100644 > >> --- a/arch/arm/boot/dts/Makefile > >> +++ b/arch/arm/boot/dts/Makefile > >> @@ -424,6 +424,8 @@ dtb-$(CONFIG_MACH_SUN7I) +=3D \ > >> sun7i-a20-pcduino3.dtb > >> dtb-$(CONFIG_MACH_SUN8I) +=3D \ > >> sun8i-a23-ippo-q8h-v5.dtb > >> +dtb-$(CONFIG_MACH_SUN9I) +=3D \ > >> + sun9i-a80-optimus.dtb > >> dtb-$(CONFIG_ARCH_TEGRA) +=3D tegra20-harmony.dtb \ > >> tegra20-iris-512.dtb \ > >> tegra20-medcom-wide.dtb \ > >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/d= ts/sun9i-a80-optimus.dts > >> new file mode 100644 > >> index 0000000..f83abab > >> --- /dev/null > >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> @@ -0,0 +1,66 @@ > >> +/* > >> + * Copyright 2014 Chen-Yu Tsai > >> + * > >> + * Chen-Yu Tsai > >> + * > >> + * This file is dual-licensed: you can use it either under the terms > >> + * of the GPL or the X11 license, at your option. Note that this dual > >> + * licensing only applies to this file, and not this project as a > >> + * whole. > >> + * > >> + * a) This library is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU General Public License as > >> + * published by the Free Software Foundation; either version 2 of= the > >> + * License, or (at your option) any later version. > >> + * > >> + * This library is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> + * GNU General Public License for more details. > >> + * > >> + * You should have received a copy of the GNU General Public > >> + * License along with this library; if not, write to the Free > >> + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > >> + * MA 02110-1301 USA > >> + * > >> + * Or, alternatively, > >> + * > >> + * b) Permission is hereby granted, free of charge, to any person > >> + * obtaining a copy of this software and associated documentation > >> + * files (the "Software"), to deal in the Software without > >> + * restriction, including without limitation the rights to use, > >> + * copy, modify, merge, publish, distribute, sublicense, and/or > >> + * sell copies of the Software, and to permit persons to whom the > >> + * Software is furnished to do so, subject to the following > >> + * conditions: > >> + * > >> + * The above copyright notice and this permission notice shall be > >> + * included in all copies or substantial portions of the Software. > >> + * > >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > >> + * OTHER DEALINGS IN THE SOFTWARE. > >> + */ > >> + > >> +/dts-v1/; > >> +/include/ "sun9i-a80.dtsi" > >> + > >> +/ { > >> + model =3D "Merrii A80 Optimus Board"; > >> + compatible =3D "merrii,a80-optimus", "allwinner,sun9i-a80"; > >> + > >> + chosen { > >> + bootargs =3D "earlyprintk console=3DttyS0,115200"; > >> + }; > > > > Since you changed the memory node in the DTSI, you should probably add > > one here too, don't you? >=20 > I thought we left fixing that to the bootloader? > I don't see any memory nodes in our other DTS. Yes, but does the A80 bootloader supports DT and actually fixes it? If not, then you'll still have to have a memory node, just like on the A31 (and presumably on the A23). Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --Wb5NtZlyOqqy58h0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUKSwoAAoJEBx+YmzsjxAgU2oP/jQj7M/91z+LgNhyI2be4Hlf 6TIMdHQzqECWIK7PSKMsLOgY4eO0KrSljZpgZ4dw57oBDqqzTvmGsOzBFxSRRN+9 LbG3VrvcJ6KYSIScWKId+XcnQUWovMPdEcebPvbH7VkMS4Xily6rhE5UevcvMyeY 9mbuh3IRtX/c8HEKkqAuV42+gGrSbgEZUZh5KfFnNzd/Lq7571cZs1vSQvBb+yF1 uvtkacgFhGDvPG0jBGd2VZ14TWWxqYTy2Mj5RaBT+GPHH0H59OskArTQ+GSJ2+RO fz6ZG36dJczypjOBYXvDu7ymeVvQoagSxkR9Fpf8XgJd9ELMTTC6OukwlpQvtaDF dMsLlYZM+7T+68tHs8Iafx8jct3mynnVTAKnxeN+93kDd0n0u2QFy4EndmVGocOY ZR9y1IEYO44Me6bRPuOPciLVQyWDq4zd4l97BkoyIyuXpFwQmoSc9LoLE0BdZ0VB j3FE9uCfmCp5aXGNIOliRLWLdaje0EFetqsbK6HIk60XU8F1tH8gqjRNGiny9vXX bh+ckntk+fpfZraitmAbE8bSMyHOvIdY1CXVrGGFXwj9ZLKhQTohRwsq3T8ouAbn 79F90DvVyiSw8m4NHJR0hc5H74u4jgXCcY+KG3Cu9PKux/rMQAlMuJZeqrLPJjcZ B6UeeQp+STq0K18SVuel =wfyW -----END PGP SIGNATURE----- --Wb5NtZlyOqqy58h0--