From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754051AbaI2J5L (ORCPT ); Mon, 29 Sep 2014 05:57:11 -0400 Received: from mga11.intel.com ([192.55.52.93]:35719 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbaI2J5J (ORCPT ); Mon, 29 Sep 2014 05:57:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,619,1406617200"; d="scan'208";a="598196353" Date: Mon, 29 Sep 2014 12:57:04 +0300 From: Mika Westerberg To: Weike Chen Cc: Eric Miao , Russell King , Haojian Zhuang , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Hock Leong Kweh , Boon Leong Ong , Raymond Tan , Andy Shevchenko Subject: Re: [PATCH 2/2 v2] SPI: spi-pxa2xx: SPI support for Intel Quark X1000 Message-ID: <20140929095704.GF1786@lahna.fi.intel.com> References: <1412000548-9908-1-git-send-email-alvin.chen@intel.com> <1412000548-9908-3-git-send-email-alvin.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412000548-9908-3-git-send-email-alvin.chen@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 29, 2014 at 07:22:28AM -0700, Weike Chen wrote: > There are two SPI controllers exported by PCI subsystem for Intel Quark X1000. > The SPI memory mapped I/O registers supported by Quark are different from > the current implementation, and Quark only supports the registers of 'SSCR0', > 'SSCR1', 'SSSR', 'SSDR', and 'DDS_RATE'. This patch is to enable the SPI for > Intel Quark X1000. > > This piece of work is derived from Dan O'Donovan's initial work for Intel Quark > X1000 SPI enabling. > > Signed-off-by: Weike Chen Same here, please fix the minor issues pointed out by Andy and then you can add, Acked-by: Mika Westerberg