From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
"Sylvain 'ythier' Hitier" <sylvain.hitier@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Vince Weaver <vincent.weaver@maine.edu>
Subject: Re: [PATCH] fork.c: copy_process(): fix cleanup WRT perf_event_free_task()
Date: Mon, 29 Sep 2014 14:07:22 +0200 [thread overview]
Message-ID: <20140929120722.GA11943@gmail.com> (raw)
In-Reply-To: <20140929101201.GE5430@worktop>
* Peter Zijlstra <peterz@infradead.org> wrote:
> Subject: perf: Fix perf bug in fork()
>
> Oleg noticed that a cleanup by Sylvain actually uncovered a bug; by
> calling perf_event_free_task() when failing sched_fork() we will not yet
> have done the memset() on ->perf_event_ctxp[] and will therefore try and
> 'free' the inherited contexts, which are still in use by the parent
> process. This is bad..
>
> Suggested-by: Oleg Nesterov <oleg@redhat.com>
> Reported-by: Oleg Nesterov <oleg@redhat.com>
> Reported-by: Sylvain 'ythier' Hitier <sylvain.hitier@gmail.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Could this fix a couple of fuzzer triggered perf crashes perhaps?
Thanks,
Ingo
next prev parent reply other threads:[~2014-09-29 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 21:06 [PATCH] fork.c: copy_process(): fix cleanup WRT perf_event_free_task() Sylvain 'ythier' Hitier
2014-09-27 18:07 ` Oleg Nesterov
2014-09-29 10:12 ` Peter Zijlstra
2014-09-29 12:07 ` Ingo Molnar [this message]
2014-09-29 14:00 ` Peter Zijlstra
2014-10-01 22:44 ` Andrew Morton
2014-09-29 22:28 ` Oleg Nesterov
2014-10-03 5:27 ` [tip:perf/urgent] perf: Fix perf bug in fork() tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929120722.GA11943@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=sylvain.hitier@gmail.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox