Re: [PATCH v3] watchdog: add driver for Ricoh RN5T618 watchdog

[Lee Jones <lee.jones@linaro.org>]

On Mon, 29 Sep 2014, Beniamino Galvani wrote:

> On Mon, Sep 29, 2014 at 08:58:45AM +0100, Lee Jones wrote:
> > I'm not sure why a) this patch was sent to me in the first place and
> > b) why anyone would think this should go in through MFD?
> > 
> 
> Hi Lee,
> 
> from a previous mail [1] I (wrongly) assumed that this was going
> through the MFD tree. If this is not the case, Wim, can you pick the
> patch?
> 
> Beniamino
> 
> [1] https://lkml.org/lkml/2014/9/4/124

Okay, I see what's happened.

So actually if there are interdependencies between this and the other
patches in the set, which I think there are, then you should have kept
this in the set with the others.  Sending as an independent patch is
not the correct thing to do.

Can you resend this, as a patch-set with all of the Acks you have
acquired please.  I will then take the set as a whole.

> > > You have my Acked-by or Signbed-off-by on this one.
> > > I believe this goes via the mfd tree.
> > 
> > Wim,
> > 
> > When you Ack something, you should add your full Acked-by string.
> > 
> > Patches should only be Signed-off(-by) when you are part of the
> > distribution path i.e. when you send patches to another Maintainer
> > and/or Linus.
> > 
> > > > This adds a driver for the watchdog timer available in Ricoh RN5T618
> > > > PMIC. The device supports a programmable expiration time of 1, 8, 32
> > > > or 128 seconds.
> > > > 
> > > > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > > ---
> > > > 
> > > > Hi,
> > > > 
> > > > this is the third version of Ricoh RN5T618 watchdog driver. The other
> > > > patches of the original series adding MFD and regulator support have
> > > > already been merged.
> > > > 
> > > > Changes since v2 (http://lwn.net/Articles/610000/ ):
> > > >   - rename 'heartbeat' module parameter to 'timeout'
> > > >   - change parameter type to uint
> > > > 
> > > > Changes since v1:
> > > >   - initialized heartbeat parameter to 0 instead of -1
> > > >   - simplified code path in set_timeout function
> > > >   - fixed module unloading
> > > >   - made 'time' unsigned in struct rn5t618_wdt_map

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog