From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719AbaI2QHm (ORCPT ); Mon, 29 Sep 2014 12:07:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37032 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754437AbaI2QHl (ORCPT ); Mon, 29 Sep 2014 12:07:41 -0400 Date: Mon, 29 Sep 2014 18:07:38 +0200 From: David Sterba To: Omar Sandoval Cc: Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] btrfs: fix sparse address space warnings Message-ID: <20140929160738.GC11436@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Omar Sandoval , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1411894092-28784-1-git-send-email-osandov@osandov.com> <1411894092-28784-2-git-send-email-osandov@osandov.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411894092-28784-2-git-send-email-osandov@osandov.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 28, 2014 at 01:48:11AM -0700, Omar Sandoval wrote: > The buffer passed to vfs_write in send and several casts of ioctl fields are > missing the __user annotation. Also fixes a couple of related trivial style > issues. > > Signed-off-by: Omar Sandoval Reviewed-by: David Sterba > @@ -639,8 +640,7 @@ static int send_header(struct send_ctx *sctx) > - return write_buf(sctx->send_filp, &hdr, sizeof(hdr), > - &sctx->send_off); > + return write_buf(sctx->send_filp, &hdr, sizeof(hdr), &sctx->send_off); > ret = write_buf(sctx->send_filp, sctx->send_buf, sctx->send_size, > - &sctx->send_off); > + &sctx->send_off); Please do not fold unrelated changes.