From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel@pengutronix.de, Grant Likely <grant.likely@linaro.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop
Date: Mon, 29 Sep 2014 12:59:37 -0400 [thread overview]
Message-ID: <20140929165937.GB13163@kroah.com> (raw)
In-Reply-To: <1411983923.3050.1.camel@pengutronix.de>
On Mon, Sep 29, 2014 at 11:45:23AM +0200, Philipp Zabel wrote:
> Am Montag, den 29.09.2014, 12:13 +0300 schrieb Dan Carpenter:
> > On Mon, Sep 29, 2014 at 10:15:44AM +0200, Philipp Zabel wrote:
> > > In preparation for a following patch, stop decrementing the endpoint node
> > > refcount in the loop. This temporarily leaks a reference to the endpoint node,
> > > which will be fixed by having of_graph_get_next_endpoint decrement the refcount
> > > of its prev argument instead.
> >
> > Don't do this...
> >
> > My understanding (and I haven't invested much time into trying to
> > understand this beyond glancing at the change) is that patch 1 and 2,
> > introduce small bugs that are fixed in patch 3?
> >
> > Just fold all three patches into one patch. We need an Ack from Mauro
> > and Greg and then send the patch through Grant's tree.
>
> Yes. Patches 1 and 2 leak a reference on of_nodes touched by the loop.
> As far as I am aware, all users of this code don't use the reference
> counting (CONFIG_OF_DYNAMIC is disabled), so this bug should be
> theoretical.
>
> I'd be happy do as you suggest if Mauro and Greg agree.
Let's see the correct patch, don't break things and then later on fix
them...
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-29 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 8:15 [PATCH v4 0/8] Add of-graph helpers to loop over endpoints and find ports by id Philipp Zabel
2014-09-29 8:15 ` [PATCH v4 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop Philipp Zabel
2014-09-29 9:13 ` Dan Carpenter
2014-09-29 9:45 ` Philipp Zabel
2014-09-29 16:59 ` Greg Kroah-Hartman [this message]
2014-09-29 8:15 ` [PATCH v4 2/8] imx-drm: " Philipp Zabel
2014-09-29 8:15 ` [PATCH v4 3/8] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint Philipp Zabel
2014-09-29 8:15 ` [PATCH v4 4/8] of: Add for_each_endpoint_of_node helper macro Philipp Zabel
2014-09-29 8:15 ` [PATCH v4 5/8] of: Add of_graph_get_port_by_id function Philipp Zabel
2014-09-29 8:15 ` [PATCH v4 6/8] drm: use for_each_endpoint_of_node macro in drm_of_find_possible_crtcs Philipp Zabel
2014-09-29 8:15 ` [PATCH v4 7/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_get_mux_id Philipp Zabel
2014-09-29 8:15 ` [PATCH v4 8/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_parse_of Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929165937.GB13163@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=g.liakhovetski@gmx.de \
--cc=grant.likely@linaro.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox