public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Sylvain 'ythier' Hitier" <sylvain.hitier@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: nhorman@tuxdriver.com, linux-kernel@vger.kernel.org, mroos@linux.ee
Subject: Re: [PATCH v2] 3c59x: fix bad split of cpu_to_le32(pci_map_single())
Date: Mon, 29 Sep 2014 21:26:55 +0000	[thread overview]
Message-ID: <20140929212655.GE15737@erable> (raw)
In-Reply-To: <20140929.160813.1739128124571074828.davem@davemloft.net>

When: 2014-09-29_1@16-08-13 -0400
Who:  David Miller
What:
> From: Sylvain 'ythier' Hitier <sylvain.hitier@gmail.com>
> Date: Mon, 29 Sep 2014 19:45:12 +0000
> 
> You should not submit patches as a reply to a discussion, it must be
> done as a fresh mailing list posting.

Ah, didn't know.
I've seen this be done before, such as:
    http://thread.gmane.org/gmane.linux.kernel/1759680/focus=1775068
and hence did the same.

And searching case-insensitively "reply", "fresh", "new", "thread" in
Documentation/SubmittingPatches shed no light on this topic.

> The posting must also be properly formed, in that "Subject: " should
> be of the form "[PATCH vx] ${subsystem}: Description."  and the mail
> message body must be the commit message with appropriate signoffs
> and ACKs, then the patch comes next.
> 
> This is fully described, in detail, in Documentation/SubmittingPatches

Ah, OK, you meant:
    Please use git format-patch so that I could use git am.

Did that.

(Thanks, you made me learn about git format-patch by myself.
That is, only describing the format makes you a
teacher-who-let-the-padawan-find-the-right-tool-by-self-work instead of a
teacher-who-gives-the-solution.)

> > Would it be OK for me re-sending my part as v3 including Neil's ack?
> > Or are you expecting a unique patch combining Neil's changes and mine?

I went for a v3.


Regards,
Sylvain "ythier" Hitier

-- 
Business is about being busy, not being rich...
Lived 777 days in a Debian package => http://en.wikipedia.org/wiki/Apt,_Vaucluse
There's THE room for ideals in this mechanical place!

      reply	other threads:[~2014-09-29 21:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  9:30 [PATCH] 3c59x: fix bad split of cpu_to_le32(pci_map_single()) Sylvain 'ythier' Hitier
2014-09-24 10:13 ` Neil Horman
2014-09-24 10:16 ` Neil Horman
2014-09-25 15:15   ` [PATCH v2] " Sylvain 'ythier' Hitier
2014-09-25 16:02     ` Neil Horman
2014-09-29 19:37     ` David Miller
2014-09-29 19:45       ` Sylvain 'ythier' Hitier
2014-09-29 20:08         ` David Miller
2014-09-29 21:26           ` Sylvain 'ythier' Hitier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140929212655.GE15737@erable \
    --to=sylvain.hitier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox