From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755095AbaI2WOK (ORCPT ); Mon, 29 Sep 2014 18:14:10 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:48705 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753861AbaI2WOH (ORCPT ); Mon, 29 Sep 2014 18:14:07 -0400 Date: Mon, 29 Sep 2014 17:14:06 -0500 From: Andy Gross To: Archit Taneja Cc: vinod.koul@intel.com, galak@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/3] dmaengine: qcom_bam_dma: Generalize BAM register offset calculations Message-ID: <20140929221406.GE11142@qualcomm.com> References: <1411037575-13153-1-git-send-email-architt@codeaurora.org> <1411965189-24499-1-git-send-email-architt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411965189-24499-1-git-send-email-architt@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 29, 2014 at 10:03:07AM +0530, Archit Taneja wrote: > The BAM DMA IP comes in different versions. The register offset layout varies > among these versions. The layouts depend on which generation/family of SoCs they > belong to. > > The current SoCs(like 8084, 8074) have a layout where the Top level registers > come in the beginning of the address range, followed by pipe and event > registers. The BAM revision numbers fall above 1.4.0. > > The older SoCs (like 8064, 8960) have a layout where the pipe registers come > first, and the top level come later. These have BAM revision numbers lesser than > 1.4.0. > > It isn't suitable to have macros provide the register offsets with the layouts > changed. Future BAM revisions may have different register layouts too. The > register addresses are now calculated by referring a table which contains a base > offset and multipliers for pipe/evnt/ee registers. > > We have a common function bam_addr() which computes addresses for all the > registers. When computing address of top level/ee registers, we pass 0 to the > pipe argument in addr() since they don't have any multiple instances. > > Some of the unused register definitions are removed. We can add new registers as > we need them. Vinod, These changes replace the patch set I had that implemented support for the v.1.3.0 register set. -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation