From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752412AbaI3T72 (ORCPT ); Tue, 30 Sep 2014 15:59:28 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:60131 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbaI3T7Y (ORCPT ); Tue, 30 Sep 2014 15:59:24 -0400 Date: Tue, 30 Sep 2014 14:59:23 -0500 From: Andy Gross To: Bjorn Andersson Cc: Wolfram Sang , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "Ivan T. Ivanov" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] i2c: qup: Fix order of runtime pm initialization Message-ID: <20140930195923.GB26928@qualcomm.com> References: <1412028051-21774-1-git-send-email-agross@codeaurora.org> <20140930015323.GE28481@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140930015323.GE28481@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 29, 2014 at 06:53:24PM -0700, Bjorn Andersson wrote: > On Mon 29 Sep 15:00 PDT 2014, Andy Gross wrote: > > > The runtime pm calls need to be done before populating the children via the > > i2c_add_adapter call. If this is not done, a child can run into issues trying > > to do i2c read/writes due to the pm_runtime_sync failing. > > > > May I ask in what case this would fail? I thought we tested this as we found > the faulty error check after calling pm_runtime_get_sync(). This is a different kind of failure. If during probe, the children do some I2C activity, they will encounter issues with the runtime_sync due to the pm_runtime not being initialized. However, once the qup probe completes, everything works fine. The original runtime_sync issue revolved around the runtime_sync return value being misinterpreted due to the incorrect check. -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation