From: Kirill Tkhai <tkhai@yandex.ru>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Kirill Tkhai <ktkhai@parallels.com>,
Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@gmail.com>
Subject: [PATCH v2 3/3] sched/fair: Delete resched_cpu() from idle_balance()
Date: Wed, 01 Oct 2014 01:04:44 +0400 [thread overview]
Message-ID: <20140930210441.5258.55054.stgit@localhost> (raw)
In-Reply-To: <20140930210412.5258.35299.stgit@localhost>
From: Kirill Tkhai <ktkhai@parallels.com>
We already reschedule env.dst_cpu in attach_tasks()->check_preempt_curr()
if this is necessary.
Furthermore, a higher priority class task may be current on dest rq,
we shouldn't disturb it.
Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
---
kernel/sched/fair.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 10a5a28..8265601 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6700,12 +6700,6 @@ static int load_balance(int this_cpu, struct rq *this_rq,
local_irq_restore(flags);
- /*
- * some other cpu did the load balance for us.
- */
- if (cur_ld_moved && env.dst_cpu != smp_processor_id())
- resched_cpu(env.dst_cpu);
-
if (env.flags & LBF_NEED_BREAK) {
env.flags &= ~LBF_NEED_BREAK;
goto more_balance;
next prev parent reply other threads:[~2014-09-30 21:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 21:04 [PATCH v2 1/3] sched/dl: Implement cancel_dl_timer() to use in switched_from_dl() Kirill Tkhai
2014-09-30 21:04 ` [PATCH v2 2/3] sched/dl: Cleanup prio_changed_dl() Kirill Tkhai
2014-10-02 9:36 ` Peter Zijlstra
2014-10-02 9:52 ` Kirill Tkhai
2014-10-21 16:24 ` Juri Lelli
2014-10-21 16:33 ` Kirill Tkhai
2014-10-22 9:33 ` Juri Lelli
2014-10-23 23:04 ` Wanpeng Li
2014-10-24 9:26 ` Juri Lelli
2014-09-30 21:04 ` Kirill Tkhai [this message]
2014-10-03 5:28 ` [tip:sched/core] sched/fair: Delete resched_cpu() from idle_balance() tip-bot for Kirill Tkhai
2014-10-02 9:34 ` [PATCH v2 1/3] sched/dl: Implement cancel_dl_timer() to use in switched_from_dl() Peter Zijlstra
2014-10-02 10:05 ` Kirill Tkhai
2014-10-21 10:30 ` Juri Lelli
2014-10-21 10:48 ` Kirill Tkhai
2014-10-21 11:41 ` Juri Lelli
2014-10-21 14:21 ` Kirill Tkhai
2014-10-22 10:00 ` Juri Lelli
2014-10-23 8:39 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930210441.5258.55054.stgit@localhost \
--to=tkhai@yandex.ru \
--cc=juri.lelli@gmail.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox