From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Kumar Gala <galak@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
Suman Anna <s-anna@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Eric Holmberg <eholmber@codeaurora.org>,
"Cavin, Courtney" <Courtney.Cavin@sonymobile.com>
Subject: Re: [PATCH v4] hwspinlock: qcom: Add support for Qualcomm HW Mutex block
Date: Tue, 30 Sep 2014 15:27:55 -0700 [thread overview]
Message-ID: <20140930222754.GX28481@sonymobile.com> (raw)
In-Reply-To: <542B2B4A.7060002@codeaurora.org>
On Tue 30 Sep 15:14 PDT 2014, Jeffrey Hugo wrote:
> On 9/29/2014 10:35 PM, Bjorn Andersson wrote:
[..]
> > +static int qcom_hwspinlock_probe(struct platform_device *pdev)
> > +{
> > + struct device_node *node = pdev->dev.of_node;
> > + const struct of_device_id *match;
> > + struct hwspinlock_device *bank;
> > + struct hwspinlock *hwlock;
> > + struct resource *res;
> > + void __iomem *iobase;
> > + unsigned stride, i;
> > + size_t array_size;
> > + u32 num_locks;
> > + int ret;
> > +
> > + match = of_match_device(qcom_hwspinlock_of_match, &pdev->dev);
> Didn't this have error handling in v2?
It did, but as this is a platform_device and we only support DTthere is no way
match will be NULL if we end up here. So the possible check would be to see
that data is non-null, but for this driver that wouldn't make sense.
Regards,
Bjorn
prev parent reply other threads:[~2014-09-30 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 4:35 [PATCH v4] hwspinlock: qcom: Add support for Qualcomm HW Mutex block Bjorn Andersson
2014-09-30 21:48 ` Suman Anna
2014-09-30 22:14 ` Bjorn Andersson
2014-09-30 22:14 ` Jeffrey Hugo
2014-09-30 22:27 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930222754.GX28481@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=Courtney.Cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=eholmber@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox