Re: [PATCH] x86, MCE, AMD: save IA32_MCi_STATUS before machine_check_poll() resets it

Borislav Petkov
2014-09-30T10:09:45Z

On Tue, Sep 30, 2014 at 05:56:31PM +0800, Chen Yucong wrote:
> I just clear it to avoid that the mce_log() call logs the above
> threshold event again in machine_check_poll().

Ok, that's a good point, please put it in the commit message.

> It is just used for scanning other banks for recording other valid
> error information.

This is actually not what we want - we want to log the errors which
cause the overflow first and then the rest. So you don't need the goto
but simply have the machine_check_poll() at the end.

Now let me repeat my question: how are you testing your patches?

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--