From: Matt Fleming <matt@console-pimps.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH 1/2] efi: Provide a non-blocking SetVariable() operation
Date: Wed, 1 Oct 2014 17:11:51 +0100 [thread overview]
Message-ID: <20141001161151.GD14343@console-pimps.org> (raw)
In-Reply-To: <20141001152624.GB2843@worktop.programming.kicks-ass.net>
On Wed, 01 Oct, at 05:26:24PM, Peter Zijlstra wrote:
>
> If you want to have this usable from NMI context, you need to convert
> efi_runtime_lock to a raw_spinlock_t.
Hmm.. I note that none of the spinlocks in the pstore code path that we
execute to get here are raw_spinlock_t. And that's the only code path
that calls this function.
They need to be raw_spinlock_t for -rt?
> Also, it would probably be a good idea to have some selftest like thing
> that actually calls this from NMI context, right?
Yeah probably, although that'd need to be a core pstore test since
there's nothing really interesting going on in
virt_efi_set_variable_nonblocking(), and it would be good to test it out
in the larger pstore context.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-10-01 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 12:06 [PATCH 0/2] efi: Remove conditional in_nmi() runtime locking Matt Fleming
2014-10-01 12:06 ` [PATCH 1/2] efi: Provide a non-blocking SetVariable() operation Matt Fleming
2014-10-01 15:26 ` Peter Zijlstra
2014-10-01 16:11 ` Matt Fleming [this message]
2014-10-01 12:06 ` [PATCH 2/2] efi: Delete the in_nmi() conditional runtime locking Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001161151.GD14343@console-pimps.org \
--to=matt@console-pimps.org \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox