public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jerry Stralko <gerb.stralko@gmail.com>
Cc: gulsah.1004@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stagging : rtl8821ae : Fixed sparse warning
Date: Wed, 1 Oct 2014 18:22:47 -0700	[thread overview]
Message-ID: <20141002012247.GC18380@kroah.com> (raw)
In-Reply-To: <542C990C.1040702@gmail.com>

On Wed, Oct 01, 2014 at 08:15:08PM -0400, Jerry Stralko wrote:
> On 09/23/2014 07:09 PM, Jerry Stralko wrote:
> > Symbol was not declared. Should it be static?
> >
> > Signed-off-by: Jerry Stralko 
> > ---
> >  drivers/staging/rtl8821ae/base.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c
> > index 4a36da0..dea3c4b 100644
> > --- a/drivers/staging/rtl8821ae/base.c
> > +++ b/drivers/staging/rtl8821ae/base.c
> > @@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
> >  
> >  /* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
> >  /* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
> > -struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
> > +static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
> >  				     enum ieee80211_smps_mode smps,
> >  				     u8 *da, u8 *bssid)
> >  {
> > @@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
> >  	return matched;
> >  }
> >  
> > -bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
> > +static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
> >  		unsigned int len)
> >  {
> >  	struct ieee80211_mgmt *mgmt = (void *)data;
> 
> Ping?

This fell out of my scripts due to the misspelled subject line, sorry.
I'll queue it up when I get a chance to go through the rest of the
"staging" patches, after 3.18-rc1 is out.

thanks,

greg k-h

  reply	other threads:[~2014-10-02  1:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 23:09 [PATCH] stagging : rtl8821ae : Fixed sparse warning Jerry Stralko
2014-10-02  0:15 ` Jerry Stralko
2014-10-02  1:22   ` Greg KH [this message]
2014-10-02 16:34 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002012247.GC18380@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gerb.stralko@gmail.com \
    --cc=gulsah.1004@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox