* [PATCH] stagging : rtl8821ae : Fixed sparse warning
@ 2014-09-23 23:09 Jerry Stralko
2014-10-02 0:15 ` Jerry Stralko
2014-10-02 16:34 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Jerry Stralko @ 2014-09-23 23:09 UTC (permalink / raw)
To: gulsah.1004, gregkh; +Cc: linux-kernel, gerb.stralko
Symbol was not declared. Should it be static?
Signed-off-by: Jerry Stralko
---
drivers/staging/rtl8821ae/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c
index 4a36da0..dea3c4b 100644
--- a/drivers/staging/rtl8821ae/base.c
+++ b/drivers/staging/rtl8821ae/base.c
@@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
/* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
/* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
-struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
+static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
enum ieee80211_smps_mode smps,
u8 *da, u8 *bssid)
{
@@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
return matched;
}
-bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
+static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
unsigned int len)
{
struct ieee80211_mgmt *mgmt = (void *)data;
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] stagging : rtl8821ae : Fixed sparse warning
2014-09-23 23:09 [PATCH] stagging : rtl8821ae : Fixed sparse warning Jerry Stralko
@ 2014-10-02 0:15 ` Jerry Stralko
2014-10-02 1:22 ` Greg KH
2014-10-02 16:34 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Jerry Stralko @ 2014-10-02 0:15 UTC (permalink / raw)
To: gulsah.1004, gregkh; +Cc: linux-kernel
On 09/23/2014 07:09 PM, Jerry Stralko wrote:
> Symbol was not declared. Should it be static?
>
> Signed-off-by: Jerry Stralko
> ---
> drivers/staging/rtl8821ae/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c
> index 4a36da0..dea3c4b 100644
> --- a/drivers/staging/rtl8821ae/base.c
> +++ b/drivers/staging/rtl8821ae/base.c
> @@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
>
> /* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
> /* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
> -struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
> +static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
> enum ieee80211_smps_mode smps,
> u8 *da, u8 *bssid)
> {
> @@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
> return matched;
> }
>
> -bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
> +static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
> unsigned int len)
> {
> struct ieee80211_mgmt *mgmt = (void *)data;
Ping?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] stagging : rtl8821ae : Fixed sparse warning
2014-10-02 0:15 ` Jerry Stralko
@ 2014-10-02 1:22 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-10-02 1:22 UTC (permalink / raw)
To: Jerry Stralko; +Cc: gulsah.1004, linux-kernel
On Wed, Oct 01, 2014 at 08:15:08PM -0400, Jerry Stralko wrote:
> On 09/23/2014 07:09 PM, Jerry Stralko wrote:
> > Symbol was not declared. Should it be static?
> >
> > Signed-off-by: Jerry Stralko
> > ---
> > drivers/staging/rtl8821ae/base.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c
> > index 4a36da0..dea3c4b 100644
> > --- a/drivers/staging/rtl8821ae/base.c
> > +++ b/drivers/staging/rtl8821ae/base.c
> > @@ -1367,7 +1367,7 @@ u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie)
> >
> > /* when we use 2 rx ants we send IEEE80211_SMPS_OFF */
> > /* when we use 1 rx ant we send IEEE80211_SMPS_STATIC */
> > -struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
> > +static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,
> > enum ieee80211_smps_mode smps,
> > u8 *da, u8 *bssid)
> > {
> > @@ -1540,7 +1540,7 @@ static bool rtl_chk_vendor_ouisub(struct ieee80211_hw *hw,
> > return matched;
> > }
> >
> > -bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
> > +static bool rtl_find_221_ie(struct ieee80211_hw *hw, u8 *data,
> > unsigned int len)
> > {
> > struct ieee80211_mgmt *mgmt = (void *)data;
>
> Ping?
This fell out of my scripts due to the misspelled subject line, sorry.
I'll queue it up when I get a chance to go through the rest of the
"staging" patches, after 3.18-rc1 is out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] stagging : rtl8821ae : Fixed sparse warning
2014-09-23 23:09 [PATCH] stagging : rtl8821ae : Fixed sparse warning Jerry Stralko
2014-10-02 0:15 ` Jerry Stralko
@ 2014-10-02 16:34 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-10-02 16:34 UTC (permalink / raw)
To: Jerry Stralko; +Cc: gulsah.1004, linux-kernel
On Tue, Sep 23, 2014 at 07:09:50PM -0400, Jerry Stralko wrote:
> Symbol was not declared. Should it be static?
>
> Signed-off-by: Jerry Stralko
> ---
> drivers/staging/rtl8821ae/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This driver is no longer in the kernel tree :(
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-02 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23 23:09 [PATCH] stagging : rtl8821ae : Fixed sparse warning Jerry Stralko
2014-10-02 0:15 ` Jerry Stralko
2014-10-02 1:22 ` Greg KH
2014-10-02 16:34 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox