From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753840AbaJBB5c (ORCPT ); Wed, 1 Oct 2014 21:57:32 -0400 Received: from ozlabs.org ([103.22.144.67]:33799 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbaJBB5b (ORCPT ); Wed, 1 Oct 2014 21:57:31 -0400 In-Reply-To: <1412073306-13812-7-git-send-email-mikey@neuling.org> To: Michael Neuling , greg@kroah.com, arnd@arndb.de, benh@kernel.crashing.org From: Michael Ellerman Cc: mikey@neuling.org, anton@samba.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, jk@ozlabs.org, imunsie@au.ibm.com, cbe-oss-dev@lists.ozlabs.org, "Aneesh Kumar K.V" Subject: Re: [PATCH v2 06/17] powerpc/powernv: Split out set MSI IRQ chip code Message-Id: <20141002015729.D379414016B@ozlabs.org> Date: Thu, 2 Oct 2014 11:57:29 +1000 (EST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-30-09 at 10:34:55 UTC, Michael Neuling wrote: > From: Ian Munsie > > Some of the MSI IRQ code in pnv_pci_ioda_msi_setup() is generically useful so > split it out. > > This will be used by some of the cxl PCIe code later. > > diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c > index df241b1..329164f 100644 > --- a/arch/powerpc/platforms/powernv/pci-ioda.c > +++ b/arch/powerpc/platforms/powernv/pci-ioda.c > @@ -1306,14 +1306,36 @@ static void pnv_ioda2_msi_eoi(struct irq_data *d) > icp_native_eoi(d); > } > > + > +static void set_msi_irq_chip(struct pnv_phb *phb, unsigned int virq) > +{ > + struct irq_data *idata; > + struct irq_chip *ichip; > + > + if (phb->type != PNV_PHB_IODA2) > + return; > + > + /* > + * Change the IRQ chip for the MSI interrupts on PHB3. > + * The corresponding IRQ chip should be populated for > + * the first time. Seeing as you're moving this comment can you clarify the wording. cheers