The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Amber Thrall <amber.rose.thrall@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/
Date: Wed, 1 Oct 2014 23:20:46 -0700	[thread overview]
Message-ID: <20141002062046.GA1558@newt.localdomain> (raw)
In-Reply-To: <1412224802-28431-1-git-send-email-amber.rose.thrall@gmail.com>

Amber,

On Wed, Oct 01, 2014 at 09:40:02PM -0700, Amber Thrall wrote:
> Fixed various coding style issues, including strings over 80 characters long and many 

Log messages are easier to read if they are less than 80 characters wide too.

I like to use a width of 72 characters.  It allows enough room for a few
replies without wrapping.

> deprecated printk's have been replaced with proper methods.
> 
> Signed-off-by: Amber Thrall <amber.rose.thrall@gmail.com>
> ---
...

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler

  parent reply	other threads:[~2014-10-02  6:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02  4:40 [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/ Amber Thrall
2014-10-02  4:49 ` Ilia Mirkin
2014-10-02  6:20 ` Jeremiah Mahler [this message]
2014-10-02 12:45 ` Greg KH
2014-10-02 13:29 ` Mauro Carvalho Chehab
2014-10-02 16:45   ` Joe Perches
2014-10-02 23:58     ` Antti Palosaari
2014-10-03  1:41       ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2014-10-02  2:35 Amber Thrall
2014-10-02  2:46 ` Greg KH
2014-10-02  8:13 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002062046.GA1558@newt.localdomain \
    --to=jmmahler@gmail.com \
    --cc=amber.rose.thrall@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox