From: Matt Fleming <matt@console-pimps.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support
Date: Thu, 2 Oct 2014 07:51:24 +0100 [thread overview]
Message-ID: <20141002065124.GF14343@console-pimps.org> (raw)
In-Reply-To: <8738b7eac2.fsf@tassilo.jf.intel.com>
On Wed, 01 Oct, at 02:42:05PM, Andi Kleen wrote:
> Matt Fleming <matt@console-pimps.org> writes:
> >
> > Changes in v2:
> >
> > - Added Jiri Olsa's Acked-by to PATCH 02/11.
> >
> > - Use x86_match_cpu() in intel_cqm_init() and make sure we grab the
> > hotplug lock to prevent races as pointed out by Andi Kleen in
> > PATCH 08/11.
> >
> > - Delete a stale comment in commit message of PATCH 10/11.
>
> No support for a modular driver?
I didn't include support for that because none of the other x86 pmu
drivers are buildable as modules. Is there a reason for that?
It's not clear to me that it would be a worthwhile change to make this
buildable as a module, since that would require a Kconfig entry and the
user would be required to make a decision regarding whether or not they
want to build CQM support.
It's much simpler to just build it in and enable it based on
CONFIG_PERF_EVENTS + CONFIG_INTEL_CPU. In fact, that's one of the things
I've always liked about the pmu drivers, if I move to a new machine and
turn on PERF_EVENTS the correct drivers will be run.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-10-02 6:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 14:36 [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support Matt Fleming
2014-10-01 14:36 ` [PATCH 01/11] perf stat: Fix AGGR_CORE segfault on multi-socket system Matt Fleming
2014-10-01 17:08 ` Arnaldo Carvalho de Melo
2014-10-01 20:37 ` Matt Fleming
2014-10-01 14:36 ` [PATCH v2 02/11] perf tools: Refactor unit and scale function parameters Matt Fleming
2014-10-01 17:09 ` Arnaldo Carvalho de Melo
2014-10-01 14:36 ` [PATCH 03/11] perf tools: Parse event per-package info files Matt Fleming
2014-10-01 14:36 ` [PATCH 04/11] perf: Make perf_cgroup_from_task() global Matt Fleming
2014-10-01 14:36 ` [PATCH 05/11] perf: Add ->count() function to read per-package counters Matt Fleming
2014-10-01 14:36 ` [PATCH 06/11] perf: Move cgroup init before PMU ->event_init() Matt Fleming
2014-10-01 14:36 ` [PATCH 07/11] x86: Add support for Intel Cache QoS Monitoring (CQM) detection Matt Fleming
2014-10-01 14:36 ` [PATCH v2 08/11] perf/x86/intel: Add Intel Cache QoS Monitoring support Matt Fleming
2014-10-01 14:36 ` [PATCH 09/11] perf/x86/intel: Implement LRU monitoring ID allocation for CQM Matt Fleming
2014-10-01 14:36 ` [PATCH v2 10/11] perf/x86/intel: Support task events with Intel CQM Matt Fleming
2014-10-01 14:36 ` [PATCH 11/11] perf/x86/intel: Perform rotation on Intel CQM RMIDs Matt Fleming
2014-10-01 21:42 ` [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support Andi Kleen
2014-10-02 6:51 ` Matt Fleming [this message]
2014-10-02 8:41 ` Peter Zijlstra
2014-10-02 15:04 ` Andi Kleen
2014-10-02 17:49 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002065124.GF14343@console-pimps.org \
--to=matt@console-pimps.org \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox