From: Dan Carpenter <dan.carpenter@oracle.com>
To: Giedrius Statkevicius <giedrius.statkevicius@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, mahati.chamarthy@gmail.com,
fabio.falzoi84@gmail.com
Subject: Re: [PATCH] staging: rts5208: Clean up coding style in rtsx_chip.c to get rid of checkpatch.pl warnings
Date: Thu, 2 Oct 2014 11:12:50 +0300 [thread overview]
Message-ID: <20141002081250.GF5865@mwanda> (raw)
In-Reply-To: <542C7C53.7060609@gmail.com>
On Thu, Oct 02, 2014 at 01:12:35AM +0300, Giedrius Statkevicius wrote:
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index 1411471..d604341 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -291,7 +291,9 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
> if (chip->dynamic_aspm) {
> if (CHK_SDIO_EXIST(chip)) {
> if (CHECK_PID(chip, 0x5288)) {
These two conditions can be combined and the indenting pulled in one
tab.
if (CHK_SDIO_EXIST(chip) && CHECK_PID(chip, 0x5288)) {
}
> @@ -988,8 +995,10 @@ void rtsx_polling_func(struct rtsx_chip *chip)
>
> turn_off_led(chip, LED_GPIO);
>
> - if (chip->auto_power_down && !chip->card_ready && !chip->sd_io)
> - rtsx_force_power_down(chip, SSC_PDCTL | OC_PDCTL);
> + if (chip->auto_power_down && !chip->card_ready &&
> + !chip->sd_io)
Line this up like this:
if (chip->auto_power_down && !chip->card_ready &&
!chip->sd_io)
[tab][tab][tab][space][space][space][space]!chip->sd_io)
> + rtsx_force_power_down(chip,
> + SSC_PDCTL | OC_PDCTL);
>
> }
> }
regards,
dan carpenter
prev parent reply other threads:[~2014-10-02 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 22:12 [PATCH] staging: rts5208: Clean up coding style in rtsx_chip.c to get rid of checkpatch.pl warnings Giedrius Statkevicius
2014-10-02 8:12 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002081250.GF5865@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=giedrius.statkevicius@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahati.chamarthy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox