From: Peter Zijlstra <peterz@infradead.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Jet Chen <jet.chen@intel.com>, Su Tao <tao.su@intel.com>,
Yuanhan Liu <yuanhan.liu@intel.com>, LKP <lkp@01.org>,
linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
oleg@redhat.com
Subject: Re: [rfcomm_run] WARNING: CPU: 1 PID: 79 at kernel/sched/core.c:7156 __might_sleep()
Date: Thu, 2 Oct 2014 15:58:05 +0200 [thread overview]
Message-ID: <20141002135805.GF6324@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20141002135250.GB10583@worktop.programming.kicks-ass.net>
On Thu, Oct 02, 2014 at 03:52:50PM +0200, Peter Zijlstra wrote:
> > If yes, then wakeups from signals don't work either, right?
>
> Its a kthread, there should not be any signals.
That said, in the tty patch we do appear to have this problem.
Oleg, do we want something like the below on top to make that work
again?
---
--- a/kernel/sched/wait.c
+++ b/kernel/sched/wait.c
@@ -326,8 +326,10 @@ long wait_woken(wait_queue_t *wait, unsi
* woken_wake_function() such that if we observe WQ_FLAG_WOKEN we must
* also observe all state before the wakeup.
*/
- if (!(wait->flags & WQ_FLAG_WOKEN))
- timeout = schedule_timeout(timeout);
+ if (!(wait->flags & WQ_FLAG_WOKEN)) {
+ if (___wait_is_interruptible(mode) && !signal_pending_state(mode, current))
+ timeout = schedule_timeout(timeout);
+ }
__set_current_state(TASK_RUNNING);
/*
next prev parent reply other threads:[~2014-10-02 13:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140930080228.GD9561@wfg-t540p.sh.intel.com>
2014-10-02 11:09 ` [rfcomm_run] WARNING: CPU: 1 PID: 79 at kernel/sched/core.c:7156 __might_sleep() Peter Zijlstra
2014-10-02 12:31 ` Peter Zijlstra
2014-10-02 12:38 ` Peter Hurley
2014-10-02 12:54 ` Peter Zijlstra
2014-10-02 13:05 ` Peter Hurley
2014-10-02 13:41 ` Peter Zijlstra
2014-10-02 12:42 ` Peter Zijlstra
2014-10-02 13:49 ` Peter Hurley
2014-10-02 13:52 ` Peter Zijlstra
2014-10-02 13:58 ` Peter Zijlstra [this message]
2014-10-02 14:16 ` Peter Hurley
2014-10-02 16:57 ` Peter Zijlstra
2014-10-02 19:18 ` Oleg Nesterov
2014-10-02 19:11 ` Oleg Nesterov
2014-10-02 19:49 ` Peter Hurley
2014-10-02 19:57 ` Peter Zijlstra
2014-10-02 20:10 ` Oleg Nesterov
2014-10-03 11:50 ` Peter Zijlstra
2014-10-03 17:56 ` Oleg Nesterov
2014-10-03 19:30 ` Oleg Nesterov
2014-10-04 8:42 ` Peter Zijlstra
2014-10-06 0:25 ` Oleg Nesterov
2014-10-06 9:19 ` Peter Zijlstra
2014-10-06 10:59 ` Paul E. McKenney
2014-10-06 16:21 ` Oleg Nesterov
2014-10-04 8:44 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002135805.GF6324@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=jet.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=marcel@holtmann.org \
--cc=oleg@redhat.com \
--cc=peter@hurleysoftware.com \
--cc=tao.su@intel.com \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).