From: Wolfram Sang <wsa@the-dreams.de>
To: Alexandru M Stan <amstan@chromium.org>
Cc: Max Schwarz <max.schwarz@online.de>,
Doug Anderson <dianders@chromium.org>,
Sonny Rao <sonnyrao@chromium.org>,
addy ke <addy.ke@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
ZhengShunQian <zhengsq@rock-chips.com>,
linux-rockchip@lists.infradead.org, heiko@sntech.de,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: rk3x: fix 0 length write transfers
Date: Fri, 3 Oct 2014 02:27:21 +0200 [thread overview]
Message-ID: <20141003002721.GC1323@katana> (raw)
In-Reply-To: <1412185241-24950-1-git-send-email-amstan@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Wed, Oct 01, 2014 at 10:40:41AM -0700, Alexandru M Stan wrote:
> i2cdetect -q was broken (everything was a false positive, and no transfers were
> actually being sent over i2c). The way it works is by sending a 0 length write
> request and checking for NACK. This patch fixes the 0 length writes and actually
> sends them.
>
> Reported-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Alexandru M Stan <amstan@chromium.org>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-10-03 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 17:40 [PATCH] i2c: rk3x: fix 0 length write transfers Alexandru M Stan
2014-10-01 22:47 ` Doug Anderson
2014-10-02 13:30 ` Max Schwarz
2014-10-03 0:27 ` Wolfram Sang
2014-10-03 0:27 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003002721.GC1323@katana \
--to=wsa@the-dreams.de \
--cc=addy.ke@rock-chips.com \
--cc=amstan@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=max.schwarz@online.de \
--cc=sonnyrao@chromium.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox