public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
	preeti@linux.vnet.ibm.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org, riel@redhat.com,
	Morten.Rasmussen@arm.com, efault@gmx.de,
	nicolas.pitre@linaro.org, linaro-kernel@lists.linaro.org,
	daniel.lezcano@linaro.org, dietmar.eggemann@arm.com,
	pjt@google.com, bsegall@google.com
Subject: Re: [PATCH v6 5/6] sched: replace capacity_factor by usage
Date: Fri, 3 Oct 2014 17:38:26 +0200	[thread overview]
Message-ID: <20141003153826.GM2849@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1411488485-10025-6-git-send-email-vincent.guittot@linaro.org>

On Tue, Sep 23, 2014 at 06:08:04PM +0200, Vincent Guittot wrote:

> This implementation of utilization_avg_contrib doesn't solve the scaling
> in-variance problem, so i have to scale the utilization with original
> capacity of the CPU in order to get the CPU usage and compare it with the
> capacity. Once the scaling invariance will have been added in
> utilization_avg_contrib, we will remove the scale of utilization_avg_contrib
> by cpu_capacity_orig in get_cpu_usage. But the scaling invariance will come
> in another patchset.

I would have expected this in the previous patch that introduced that
lot. Including a few words on how/why the cpu_capacity is a 'good'
approximation etc..

> Finally, the sched_group->sched_group_capacity->capacity_orig has been removed
> because it's more used during load balance.

That sentence is a contradiction, I expect there's a negative gone
missing someplace.

  parent reply	other threads:[~2014-10-03 15:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 16:07 [PATCH v6 0/6] sched: consolidation of cpu_capacity Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 1/6] sched: add per rq cpu_capacity_orig Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 2/6] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 3/6] sched: add utilization_avg_contrib Vincent Guittot
2014-10-03 14:15   ` Peter Zijlstra
2014-10-03 14:44     ` Vincent Guittot
2014-10-03 14:36   ` Peter Zijlstra
2014-10-03 14:51     ` Vincent Guittot
2014-10-03 15:14       ` Peter Zijlstra
2014-10-03 16:05         ` Morten Rasmussen
2014-09-23 16:08 ` [PATCH v6 4/6] sched: get CPU's usage statistic Vincent Guittot
2014-09-25 19:05   ` Dietmar Eggemann
2014-09-26 12:17     ` Vincent Guittot
2014-09-26 15:58       ` Morten Rasmussen
2014-09-26 19:57       ` Dietmar Eggemann
2014-11-21  5:36       ` Wanpeng Li
2014-11-21 12:17         ` Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 5/6] sched: replace capacity_factor by usage Vincent Guittot
2014-09-24 17:48   ` Dietmar Eggemann
2014-09-25  8:35     ` Vincent Guittot
2014-09-25 19:19       ` Dietmar Eggemann
2014-09-26 12:39         ` Vincent Guittot
2014-09-26 14:00           ` Dietmar Eggemann
2014-09-25  8:38   ` Vincent Guittot
2014-09-29 13:39   ` Dietmar Eggemann
2014-10-02 16:57   ` Morten Rasmussen
2014-10-03  7:24     ` Vincent Guittot
2014-10-03  9:35       ` Morten Rasmussen
2014-10-03 12:50         ` Vincent Guittot
2014-11-23  0:22           ` Wanpeng Li
2014-11-24  8:26             ` Vincent Guittot
2014-10-03 15:38   ` Peter Zijlstra [this message]
2014-10-06  8:55     ` Vincent Guittot
2014-09-23 16:08 ` [PATCH v6 6/6] sched: add SD_PREFER_SIBLING for SMT level Vincent Guittot
2014-09-24 12:27   ` Preeti U Murthy
2014-09-25 12:10     ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141003153826.GM2849@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Morten.Rasmussen@arm.com \
    --cc=bsegall@google.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=efault@gmx.de \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=pjt@google.com \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox