From: Josh Triplett <josh@joshtriplett.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Eric Paris" <eparis@redhat.com>, "Michal Hocko" <mhocko@suse.cz>,
"Matt Turner" <mattst88@gmail.com>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
蔡正龙 <zhenglong.cai@cs2c.com.cn>, "Tejun Heo" <tj@kernel.org>,
"Fabian Frederick" <fabf@skynet.be>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"Peter Foley" <pefoley2@pefoley.com>,
"Konstantin Khlebnikov" <koct9i@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Oleg Nesterov" <oleg@redhat.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu
Date: Fri, 3 Oct 2014 16:31:44 -0700 [thread overview]
Message-ID: <20141003233139.GA16079@thin> (raw)
commit 03b8c7b623c80af264c4c8d6111e5c6289933666 ("futex: Allow
architectures to skip futex_atomic_cmpxchg_inatomic() test") added the
HAVE_FUTEX_CMPXCHG symbol right below FUTEX. This placed it right in
the middle of the options for the EXPERT menu. However,
HAVE_FUTEX_CMPXCHG does not depend on EXPERT or FUTEX, so Kconfig stops
placing items in the EXPERT menu, and displays the remaining several
EXPERT items (starting with EPOLL) directly in the General Setup menu.
Since both users of HAVE_FUTEX_CMPXCHG only select it "if FUTEX", make
HAVE_FUTEX_CMPXCHG itself depend on FUTEX. With this change, the
subsequent items display as part of the EXPERT menu again; the EMBEDDED
menu now appears as the next top-level item in the General Setup menu,
which makes General Setup much shorter and more usable.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
Posting for review. I can upstream this through the tiny tree.
Personally, I'd consider this a bit of a bug in Kconfig; ideally,
Kconfig should only consider symbols with prompt strings when
considering what to display in a menu. However, in the interim, this
one-line patch drastically improves the usability of the "General Setup"
config menu.
init/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/init/Kconfig b/init/Kconfig
index 31505a5..80a6907 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1477,6 +1477,7 @@ config FUTEX
config HAVE_FUTEX_CMPXCHG
bool
+ depends on FUTEX
help
Architectures should select this if futex_atomic_cmpxchg_inatomic()
is implemented and always working. This removes a couple of runtime
--
2.1.1
next reply other threads:[~2014-10-03 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 23:31 Josh Triplett [this message]
2014-10-03 23:36 ` [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu Randy Dunlap
2014-10-03 23:47 ` Josh Triplett
2014-10-04 0:00 ` Randy Dunlap
2014-10-04 0:17 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003233139.GA16079@thin \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=fabf@skynet.be \
--cc=hpa@zytor.com \
--cc=koct9i@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mcgrof@suse.com \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=pefoley2@pefoley.com \
--cc=tj@kernel.org \
--cc=yann.morin.1998@free.fr \
--cc=zhenglong.cai@cs2c.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox