From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbaJFOnZ (ORCPT ); Mon, 6 Oct 2014 10:43:25 -0400 Received: from top.free-electrons.com ([176.31.233.9]:56338 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751344AbaJFOnY (ORCPT ); Mon, 6 Oct 2014 10:43:24 -0400 Date: Mon, 6 Oct 2014 16:43:21 +0200 From: Alexandre Belloni To: Thierry Reding Cc: Maxime Ripard , jonsmirl@gmail.com, Simon , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7 1/2] pwm: Add Allwinner SoC support Message-ID: <20141006144320.GF15599@piout.net> References: <1410983638-24915-1-git-send-email-alexandre.belloni@free-electrons.com> <1410983638-24915-2-git-send-email-alexandre.belloni@free-electrons.com> <20141006132404.GC26921@ulmo> <20141006143008.GC15599@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141006143008.GC15599@piout.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oops, missing line: On 06/10/2014 at 16:30:08 +0200, Alexandre Belloni wrote : > > > +static const u32 prescaler_table[] = { > > > + 120, > > > + 180, > > > + 240, > > > + 360, > > > + 480, > > > + 0, > > > + 0, > > > + 0, > > > + 12000, > > > + 24000, > > > + 36000, > > > + 48000, > > > + 72000, > > > + 0, > > > + 0, > > > + 0, /* Actually 1 but tested separately */ > > > +}; > > > > Did I already mention that this was really weird? > > > > I'm not sure what you want to do here then. This is simply coming from > the datasheet. The last one (0xF) being a bypass is actually only existing on A20 and later. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com