From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbaJFVky (ORCPT ); Mon, 6 Oct 2014 17:40:54 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:61674 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbaJFVkx (ORCPT ); Mon, 6 Oct 2014 17:40:53 -0400 Date: Mon, 6 Oct 2014 22:40:47 +0100 From: Lee Jones To: Vinod Koul Cc: linux-kernel@vger.kernel.org, subhransu.s.prusty@intel.com, Linus Walleij , Samuel Ortiz , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 11/27] mfd: ab8500-gpadc: use pm_runtime_last_busy_and_autosuspend helper Message-ID: <20141006214047.GI18035@lee--X1> References: <1411575342-31048-1-git-send-email-vinod.koul@intel.com> <1411575342-31048-12-git-send-email-vinod.koul@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1411575342-31048-12-git-send-email-vinod.koul@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Sep 2014, Vinod Koul wrote: > Use the new pm_runtime_last_busy_and_autosuspend helper instead of open > coding the same code > > Signed-off-by: Vinod Koul > --- > drivers/mfd/ab8500-gpadc.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) Applied with Linus' Ack. > diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c > index 36000f9..46bea3a 100644 > --- a/drivers/mfd/ab8500-gpadc.c > +++ b/drivers/mfd/ab8500-gpadc.c > @@ -571,8 +571,7 @@ int ab8500_gpadc_double_read_raw(struct ab8500_gpadc *gpadc, u8 channel, > } > > /* Disable VTVout LDO this is required for GPADC */ > - pm_runtime_mark_last_busy(gpadc->dev); > - pm_runtime_put_autosuspend(gpadc->dev); > + pm_runtime_last_busy_and_autosuspend(gpadc->dev); > > mutex_unlock(&gpadc->ab8500_gpadc_lock); > > @@ -910,8 +909,7 @@ static int ab8500_gpadc_resume(struct device *dev) > if (ret) > dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret); > > - pm_runtime_mark_last_busy(gpadc->dev); > - pm_runtime_put_autosuspend(gpadc->dev); > + pm_runtime_last_busy_and_autosuspend(gpadc->dev); > > mutex_unlock(&gpadc->ab8500_gpadc_lock); > return ret; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog