From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbaJGJYc (ORCPT ); Tue, 7 Oct 2014 05:24:32 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:50607 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535AbaJGJY3 (ORCPT ); Tue, 7 Oct 2014 05:24:29 -0400 Date: Tue, 7 Oct 2014 10:24:24 +0100 From: Lee Jones To: Johan Hovold Cc: Samuel Ortiz , Jiri Kosina , linux-input@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 4/6] mfd: use mfd_add_hotplug_devices helper Message-ID: <20141007092424.GT25331@lee--X1> References: <1411728933-13351-1-git-send-email-johan@kernel.org> <1411728933-13351-5-git-send-email-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1411728933-13351-5-git-send-email-johan@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Sep 2014, Johan Hovold wrote: > Use mfd_add_hotplug_devices helper to register the subdevices. > > Signed-off-by: Johan Hovold > --- > drivers/mfd/rtsx_usb.c | 4 ++-- > drivers/mfd/viperboard.c | 5 ++--- > 2 files changed, 4 insertions(+), 5 deletions(-) Applied for v3.19. > diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c > index 78073e4b87e4..5b17339fce7c 100644 > --- a/drivers/mfd/rtsx_usb.c > +++ b/drivers/mfd/rtsx_usb.c > @@ -647,8 +647,8 @@ static int rtsx_usb_probe(struct usb_interface *intf, > /* initialize USB SG transfer timer */ > setup_timer(&ucr->sg_timer, rtsx_usb_sg_timed_out, (unsigned long) ucr); > > - ret = mfd_add_devices(&intf->dev, PLATFORM_DEVID_AUTO, rtsx_usb_cells, > - ARRAY_SIZE(rtsx_usb_cells), NULL, 0, NULL); > + ret = mfd_add_hotplug_devices(&intf->dev, rtsx_usb_cells, > + ARRAY_SIZE(rtsx_usb_cells)); > if (ret) > goto out_init_fail; > > diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c > index 3c2b8f9e3c84..be450ebcb52d 100644 > --- a/drivers/mfd/viperboard.c > +++ b/drivers/mfd/viperboard.c > @@ -93,9 +93,8 @@ static int vprbrd_probe(struct usb_interface *interface, > version >> 8, version & 0xff, > vb->usb_dev->bus->busnum, vb->usb_dev->devnum); > > - ret = mfd_add_devices(&interface->dev, PLATFORM_DEVID_AUTO, > - vprbrd_devs, ARRAY_SIZE(vprbrd_devs), NULL, 0, > - NULL); > + ret = mfd_add_hotplug_devices(&interface->dev, vprbrd_devs, > + ARRAY_SIZE(vprbrd_devs)); > if (ret != 0) { > dev_err(&interface->dev, "Failed to add mfd devices to core."); > goto error; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog