From: Chuck Ebbert <cebbert.lkml@gmail.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org, jolsa@redhat.com,
peterz@infradead.org, mingo@elte.hu, dsahern@gmail.com
Subject: Re: [PATCH v2] perf tools: fix off-by-one error in maps
Date: Tue, 7 Oct 2014 13:58:38 -0500 [thread overview]
Message-ID: <20141007135838.5e3e364c@as> (raw)
In-Reply-To: <20141007140050.GB2256@redhat.com>
On Tue, 7 Oct 2014 11:00:50 -0300
Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> I keep thinking that this change is making things unclear.
>
> I.e. the _start_ of a map (map->start) is _in_ the map, and the _end_
> of a map (map->end) is _in_ the map as well.
>
> if (addr > m->end)
>
> is shorter than:
>
> if (addr >= m->end)
>
> "start" and "end" should have the same rule applied, i.e. if one is in,
> the other is in as well.
>
> Etc.
>
But the convention used in the memory management code is that "end" is
the next byte after the memory region. This gives you:
size = end - start
end = start + size
Using a different convention here will just confuse people used to the
way it's done everywhere else.
next prev parent reply other threads:[~2014-10-07 18:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 8:35 [PATCH v2] perf tools: fix off-by-one error in maps Stephane Eranian
2014-10-07 5:47 ` Namhyung Kim
2014-10-07 8:40 ` Stephane Eranian
2014-10-07 14:00 ` Arnaldo Carvalho de Melo
2014-10-07 14:17 ` Stephane Eranian
2014-10-07 15:10 ` Arnaldo Carvalho de Melo
2014-10-07 15:17 ` Stephane Eranian
2014-10-14 18:58 ` Arnaldo Carvalho de Melo
2014-10-14 19:03 ` Stephane Eranian
2014-10-14 19:24 ` Arnaldo Carvalho de Melo
2014-10-07 18:58 ` Chuck Ebbert [this message]
2014-10-08 15:53 ` Arnaldo Carvalho de Melo
2014-10-14 19:04 ` Arnaldo Carvalho de Melo
2014-10-15 10:05 ` [tip:perf/urgent] perf tools: Fixup off-by-one comparision in maps__find tip-bot for Namhyung Kim
2014-10-15 10:05 ` [tip:perf/urgent] perf tools: fix off-by-one error in maps tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007135838.5e3e364c@as \
--to=cebbert.lkml@gmail.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).