Re: [PATCHv2] phy: omap-usb2: Enable runtime PM of omap-usb2 phy properly

Oussama Ghorbel
2014-10-08T10:55:18Z

Hi Roger,

Should I resend this v2 version of the patch to stable@vger.kernel.org
which is suitable for v3.17 and which will require a very tiny adaptation?
Or I should resend the first version of this patch which is suitable for
3.16 but might seems confusing a little sine I'm resend the outdated
version.

Thanks,
Oussama
On 10/08/2014 09:17 AM, Roger Quadros wrote:
> Hi Oussama,
>
> On 10/07/2014 02:02 PM, Oussama Ghorbel wrote:
>> The USB OTG port does not work since v3.16 on omap platform.
>> This is a regression introduced by the commit
>> eb82a3d846fa (phy: omap-usb2: Balance pm_runtime_enable() on probe failure
>> and remove).
>> This because the call to pm_runtime_enable() function is moved after the
>> call to devm_phy_create() function, which has side effect since later in
>> the subsequent calls of devm_phy_create() there is a check with
>> pm_runtime_enabled() to configure few things.
>>
>> Signed-off-by: Oussama Ghorbel <ghorbel@pivasoftware.com>
> Acked-by: Roger Quadros <rogerq@ti.com>
>
> Could you please send the patch to
> Cc: <stable@vger.kernel.org> [3.16+]
>
> That way it will get into 3.16 onwards. Thanks.
>
> cheers,
> -roger
>