From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Ashley Lai <ashley@ashleylai.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
linux-api@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH v2 6/7] tpm: TPM 2.0 CRB Interface
Date: Tue, 7 Oct 2014 11:54:35 -0600 [thread overview]
Message-ID: <20141007175435.GC10432@obsidianresearch.com> (raw)
In-Reply-To: <1412701277-27794-7-git-send-email-jarkko.sakkinen@linux.intel.com>
On Tue, Oct 07, 2014 at 08:01:16PM +0300, Jarkko Sakkinen wrote:
> + rc = tpm_chip_register(chip);
> + if (rc)
> + return -ENODEV;
Again, wrong order, this needs to be last in the probe function
Jason
next prev parent reply other threads:[~2014-10-07 17:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 17:01 [PATCH v2 0/7] TPM 2.0 support Jarkko Sakkinen
2014-10-07 17:01 ` [PATCH v2 1/7] tpm: merge duplicate transmit_cmd() functions Jarkko Sakkinen
2014-10-07 17:01 ` [PATCH v2 2/7] tpm: two-phase chip management functions Jarkko Sakkinen
2014-10-07 17:50 ` [tpmdd-devel] " Jason Gunthorpe
2014-10-07 18:04 ` Jarkko Sakkinen
2014-10-07 18:27 ` Jason Gunthorpe
2014-10-07 19:15 ` Jarkko Sakkinen
2014-10-07 22:28 ` Jarkko Sakkinen
2014-10-07 22:34 ` Jason Gunthorpe
2014-10-09 9:07 ` Jarkko Sakkinen
2014-10-07 17:01 ` [PATCH v2 3/7] tpm: clean up tpm_tis driver life-cycle Jarkko Sakkinen
2014-10-07 17:53 ` [tpmdd-devel] " Jason Gunthorpe
2014-10-07 17:01 ` [PATCH v2 4/7] tpm: TPM 2.0 commands Jarkko Sakkinen
2014-10-07 17:01 ` [PATCH v2 5/7] tpm: TPM 2.0 sysfs attributes Jarkko Sakkinen
2014-10-07 17:01 ` [PATCH v2 6/7] tpm: TPM 2.0 CRB Interface Jarkko Sakkinen
2014-10-07 17:54 ` Jason Gunthorpe [this message]
2014-10-07 17:01 ` [PATCH v2 7/7] tpm: TPM 2.0 FIFO Interface Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007175435.GC10432@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=ashley@ashleylai.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).