From: Peter Zijlstra <peterz@infradead.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Matt Fleming <matt.fleming@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 04/11] perf: Make perf_cgroup_from_task() global
Date: Tue, 7 Oct 2014 20:51:57 +0200 [thread overview]
Message-ID: <20141007185157.GA4750@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1411567455-31264-5-git-send-email-matt@console-pimps.org>
On Wed, Sep 24, 2014 at 03:04:08PM +0100, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> Move perf_cgroup_from_task() from kernel/events to include/ along with
> the necessary struct definitions, so that it can be used by the PMU
> code.
>
> The upcoming Intel Cache Monitoring PMU driver assigns monitoring IDs
> based on a task's association with a cgroup - all tasks in the same
> cgroup share an ID. We can use perf_cgroup_from_task() to track this
> association.
Not yet having read the rest of the patches and maybe understanding
things wrong, that doesn't sound right.
The RMID should be associated with events, not groups. The event can be
associated with whatever perf provides {task, cgroup, cpu}.
next prev parent reply other threads:[~2014-10-07 18:52 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 14:04 [PATCH 00/11] perf: Intel Cache QoS Monitoring support Matt Fleming
2014-09-24 14:04 ` [PATCH 01/11] perf stat: Fix AGGR_CORE segfault on multi-socket system Matt Fleming
2014-09-24 14:04 ` [PATCH 02/11] perf tools: Refactor unit and scale function parameters Matt Fleming
2014-09-29 9:21 ` Jiri Olsa
2014-10-03 5:25 ` [tip:perf/core] " tip-bot for Matt Fleming
2014-09-24 14:04 ` [PATCH 03/11] perf tools: Parse event per-package info files Matt Fleming
2014-09-24 14:04 ` [PATCH 04/11] perf: Make perf_cgroup_from_task() global Matt Fleming
2014-10-07 18:51 ` Peter Zijlstra [this message]
2014-10-08 10:27 ` Matt Fleming
2014-09-24 14:04 ` [PATCH 05/11] perf: Add ->count() function to read per-package counters Matt Fleming
2014-09-24 14:04 ` [PATCH 06/11] perf: Move cgroup init before PMU ->event_init() Matt Fleming
2014-10-07 19:34 ` Peter Zijlstra
2014-10-08 10:32 ` Matt Fleming
2014-10-08 10:49 ` Peter Zijlstra
2014-09-24 14:04 ` [PATCH 07/11] x86: Add support for Intel Cache QoS Monitoring (CQM) detection Matt Fleming
2014-09-24 14:04 ` [PATCH 08/11] perf/x86/intel: Add Intel Cache QoS Monitoring support Matt Fleming
2014-09-24 16:40 ` Andi Kleen
2014-09-24 20:27 ` Matt Fleming
2014-09-24 20:39 ` Andi Kleen
2014-09-29 18:51 ` Matt Fleming
2014-10-07 19:43 ` Peter Zijlstra
2014-10-08 10:36 ` Matt Fleming
2014-10-08 12:15 ` Matt Fleming
2014-10-08 14:47 ` Peter Zijlstra
2014-10-08 20:51 ` Peter Zijlstra
2014-09-24 14:04 ` [PATCH 09/11] perf/x86/intel: Implement LRU monitoring ID allocation for CQM Matt Fleming
2014-10-08 9:51 ` Peter Zijlstra
2014-10-08 10:53 ` Matt Fleming
2014-09-24 14:04 ` [PATCH 10/11] perf/x86/intel: Support task events with Intel CQM Matt Fleming
2014-09-24 14:45 ` Matt Fleming
2014-10-08 10:01 ` Peter Zijlstra
2014-10-08 11:07 ` Peter Zijlstra
2014-10-08 12:10 ` Matt Fleming
2014-10-08 14:49 ` Peter Zijlstra
2014-10-10 12:02 ` Matt Fleming
2014-10-10 14:02 ` Peter Zijlstra
2014-10-10 10:54 ` Peter Zijlstra
2014-10-10 11:10 ` Matt Fleming
2014-09-24 14:04 ` [PATCH 11/11] perf/x86/intel: Perform rotation on Intel CQM RMIDs Matt Fleming
2014-10-08 11:19 ` Peter Zijlstra
2014-10-08 11:56 ` Matt Fleming
2014-10-08 18:08 ` Peter Zijlstra
2014-10-08 19:02 ` Thomas Gleixner
2014-10-08 19:59 ` Matt Fleming
2014-10-08 18:10 ` Peter Zijlstra
2014-10-08 20:04 ` Matt Fleming
-- strict thread matches above, loose matches on Subject: below --
2014-10-01 14:36 [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support Matt Fleming
2014-10-01 14:36 ` [PATCH 04/11] perf: Make perf_cgroup_from_task() global Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007185157.GA4750@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).