From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754910AbaJGUPX (ORCPT ); Tue, 7 Oct 2014 16:15:23 -0400 Received: from top.free-electrons.com ([176.31.233.9]:36698 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751029AbaJGUPF (ORCPT ); Tue, 7 Oct 2014 16:15:05 -0400 Date: Tue, 7 Oct 2014 22:12:35 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel , devicetree , linux-kernel , Shuge , Meng Zhang , ctl , Gregory CLEMENT Subject: Re: [PATCH v2 4/7] ARM: dts: sun9i: Add A80 Optimus Board support Message-ID: <20141007201235.GG17925@lukather> References: <1411570141-29960-1-git-send-email-wens@csie.org> <1411570141-29960-5-git-send-email-wens@csie.org> <20140925133427.GI15315@lukather> <20140929095344.GE4388@lukather> <20141001100341.GJ6884@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vSsTm1kUtxIHoa7M" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vSsTm1kUtxIHoa7M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 06, 2014 at 03:02:24PM +0800, Chen-Yu Tsai wrote: > On Wed, Oct 1, 2014 at 6:03 PM, Maxime Ripard > wrote: > > On Mon, Sep 29, 2014 at 06:04:50PM +0800, Chen-Yu Tsai wrote: > >> On Mon, Sep 29, 2014 at 5:53 PM, Maxime Ripard > >> wrote: > >> > On Sat, Sep 27, 2014 at 09:10:48PM +0800, Chen-Yu Tsai wrote: > >> >> On Thu, Sep 25, 2014 at 9:34 PM, Maxime Ripard > >> >> wrote: > >> >> > On Wed, Sep 24, 2014 at 10:48:58PM +0800, Chen-Yu Tsai wrote: > >> >> >> The A80 Optimus Board is was launched with the Allwinner A80 SoC. > >> >> >> It was jointly developed by Allwinner and Merrii. > >> >> >> > >> >> >> This board has a UART port, a JTAG connector, USB host ports, a = USB > >> >> >> 3.0 OTG connector, an HDMI output, a micro SD slot, 8G NAND flas= h, > >> >> >> 4G DRAM, a camera sensor interface, a WiFi/BT combo chip, a head= phone > >> >> >> jack, IR receiver, and additional GPIO headers. > >> >> >> > >> >> >> This patch adds only basic support. > >> >> >> > >> >> >> Signed-off-by: Chen-Yu Tsai > >> >> >> --- > >> >> >> arch/arm/boot/dts/Makefile | 2 + > >> >> >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 66 ++++++++++++++++++= +++++++++++++++ > >> >> >> 2 files changed, 68 insertions(+) > >> >> >> create mode 100644 arch/arm/boot/dts/sun9i-a80-optimus.dts > >> >> >> > >> >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Make= file > >> >> >> index 2f42b18..098f319 100644 > >> >> >> --- a/arch/arm/boot/dts/Makefile > >> >> >> +++ b/arch/arm/boot/dts/Makefile > >> >> >> @@ -424,6 +424,8 @@ dtb-$(CONFIG_MACH_SUN7I) +=3D \ > >> >> >> sun7i-a20-pcduino3.dtb > >> >> >> dtb-$(CONFIG_MACH_SUN8I) +=3D \ > >> >> >> sun8i-a23-ippo-q8h-v5.dtb > >> >> >> +dtb-$(CONFIG_MACH_SUN9I) +=3D \ > >> >> >> + sun9i-a80-optimus.dtb > >> >> >> dtb-$(CONFIG_ARCH_TEGRA) +=3D tegra20-harmony.dtb \ > >> >> >> tegra20-iris-512.dtb \ > >> >> >> tegra20-medcom-wide.dtb \ > >> >> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/= boot/dts/sun9i-a80-optimus.dts > >> >> >> new file mode 100644 > >> >> >> index 0000000..f83abab > >> >> >> --- /dev/null > >> >> >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> >> >> @@ -0,0 +1,66 @@ > >> >> >> +/* > >> >> >> + * Copyright 2014 Chen-Yu Tsai > >> >> >> + * > >> >> >> + * Chen-Yu Tsai > >> >> >> + * > >> >> >> + * This file is dual-licensed: you can use it either under the = terms > >> >> >> + * of the GPL or the X11 license, at your option. Note that thi= s dual > >> >> >> + * licensing only applies to this file, and not this project as= a > >> >> >> + * whole. > >> >> >> + * > >> >> >> + * a) This library is free software; you can redistribute it a= nd/or > >> >> >> + * modify it under the terms of the GNU General Public Lice= nse as > >> >> >> + * published by the Free Software Foundation; either versio= n 2 of the > >> >> >> + * License, or (at your option) any later version. > >> >> >> + * > >> >> >> + * This library is distributed in the hope that it will be = useful, > >> >> >> + * but WITHOUT ANY WARRANTY; without even the implied warra= nty of > >> >> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Se= e the > >> >> >> + * GNU General Public License for more details. > >> >> >> + * > >> >> >> + * You should have received a copy of the GNU General Public > >> >> >> + * License along with this library; if not, write to the Fr= ee > >> >> >> + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, = Boston, > >> >> >> + * MA 02110-1301 USA > >> >> >> + * > >> >> >> + * Or, alternatively, > >> >> >> + * > >> >> >> + * b) Permission is hereby granted, free of charge, to any per= son > >> >> >> + * obtaining a copy of this software and associated documen= tation > >> >> >> + * files (the "Software"), to deal in the Software without > >> >> >> + * restriction, including without limitation the rights to = use, > >> >> >> + * copy, modify, merge, publish, distribute, sublicense, an= d/or > >> >> >> + * sell copies of the Software, and to permit persons to wh= om the > >> >> >> + * Software is furnished to do so, subject to the following > >> >> >> + * conditions: > >> >> >> + * > >> >> >> + * The above copyright notice and this permission notice sh= all be > >> >> >> + * included in all copies or substantial portions of the So= ftware. > >> >> >> + * > >> >> >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF AN= Y KIND, > >> >> >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WAR= RANTIES > >> >> >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > >> >> >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRI= GHT > >> >> >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABIL= ITY, > >> >> >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARI= SING > >> >> >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE U= SE OR > >> >> >> + * OTHER DEALINGS IN THE SOFTWARE. > >> >> >> + */ > >> >> >> + > >> >> >> +/dts-v1/; > >> >> >> +/include/ "sun9i-a80.dtsi" > >> >> >> + > >> >> >> +/ { > >> >> >> + model =3D "Merrii A80 Optimus Board"; > >> >> >> + compatible =3D "merrii,a80-optimus", "allwinner,sun9i-a80"; > >> >> >> + > >> >> >> + chosen { > >> >> >> + bootargs =3D "earlyprintk console=3DttyS0,115200"; > >> >> >> + }; > >> >> > > >> >> > Since you changed the memory node in the DTSI, you should probabl= y add > >> >> > one here too, don't you? > >> >> > >> >> I thought we left fixing that to the bootloader? > >> >> I don't see any memory nodes in our other DTS. > >> > > >> > Yes, but does the A80 bootloader supports DT and actually fixes it? = If > >> > not, then you'll still have to have a memory node, just like on the > >> > A31 (and presumably on the A23). > >> > >> Not at the moment no. But last I checked none of our board dts files > >> have separate memory nodes. We only have them in the dtsi, with the > >> largest supported ram size as its value. Also the bootloader > >> (u-boot that is) can pass the memory size via atags I think. > > > > Only if CONFIG_ARM_ATAG_DTB_COMPAT is set. >=20 > Right. Last time I checked, this is set in both sunxi_defconfig > and multiv7_defconfig. >=20 > >> At least I'm only getting 512MB RAM on my Optimus, due to u-boot > >> incorrectly assuming I only have as much. But that's another problem. = :( > > > > And does it initialize the rest of the memory? >=20 > It does. Very weird. But it may have something to do with the u-boot > blob not being patched with all dram parameters. Interesting :) > >> Would this be a problem when using Android fastboot from the stock > >> u-boot? > > > > IIRC, fastboot passes ATAGS anyway, so as long as you have the > > configuration option mentionned above, you should be safe. >=20 > I take this as an OK for this patch? Hmmm, yep, I guess :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --vSsTm1kUtxIHoa7M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIbBAEBAgAGBQJUNEkyAAoJEBx+YmzsjxAglhwP+JLlAfsPFEYixYF2usOryl6a lE2wHewZwHfG7jS0k4VaHjeGvB6xQqeB4D0bvKfw0TErdhPMQ4OvKMmUb8C01eBZ SpzQAwzXSPE85uL7H/Q9qWWj+3vehjaqCHUqmIpWlQCKok/K9zP/P4e7PqROQj0O TNW9O7GoA0GhJ/Sd7NVOAavsNCWxQgY8ZYK3UVSrhAb0JilW51W6qfcHj6jdkzxG rPLZNT07TPsg+XxDZq/5+XbU97Mo9+mMxnyTaSN9R7I72fGEGIMPhgxK8tIPO/Fe Pa14SVzQZ39TEHnsNgg0WJgB83YHwIEJSR6KKnqraaq6PFW8RYlGNx9ryHgbrE2Q 1XHjE4bYM6x9Ql7F4JuVyglQqhx1c+To9NZoIFYeDHqIHnV/l2qykeilAhJbG0qk 98i0K6baM1QbByUFsYELjB4RtlmlGehWl5Ik3NSc8/Qn/wyrszuFzhVdaMvzOaWs lDQTPLIZYm1GK4mPswtbtlBEcH5LILfYKGB1a8l8QAjltJR442wF8DEPsPBFn9qe ZNSeOswT2Mzfi1T0LmMX/YoUBNWrqYafbsICrIvrEMDKOMGvzIESbMNAE8XNgzfg ETvt6jBObmsjE9xdp8BktOOTufzKsIXS7CBtnmtBUbUJwquhkWo7rMuzNfcXfURB 56+cOFffQNrzV1we5nU= =6iLV -----END PGP SIGNATURE----- --vSsTm1kUtxIHoa7M--