Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

Gyungoh Yoo
2014-10-17T09:20:05Z

On Tue, Oct 14, 2014 at 09:56:06AM +0200, Mark Brown wrote:
> On Tue, Oct 14, 2014 at 10:11:12AM +0900, Gyungoh Yoo wrote:
> > On Mon, Oct 13, 2014 at 12:35:12PM +0200, Mark Brown wrote:
>
> > > If you're doing anything here you should convert the code to use the
> > > simplified interface for parsing regulator data based on putting the
> > > subnode name and regualtor name in the regulator descriptor.
>
> > Thank you for the review.
>
> > The driver has of_device_id.
>
> > static const struct of_device_id sky81452_reg_of_match[] = {
> > { .compatible = "skyworks,sky81452-regulator", },
> > { }
> > };
>
> > And the MFD adds the driver with of_compatible="skyworks,sky81452-regulator".
> > MFD core maps the device node and the regulator driver does
> > not need to parse the subnode name.
>
> No, that's for the device (and as I say I don't think this is a good
> idea). I'm talking about the parsing of the constraints from the DT.

Wow. I understand.
I missed .supply_name. I think I need something like
below, before devm_regulator_register().

config->supply_name = init_data->constraints.name;

I will resubmit it.
Thank you so much.