Re: [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver

Paul Bolle
2014-11-03T21:28:16Z

On Mon, 2014-11-03 at 17:14 +0000, Lee Jones wrote:
>On Fri, 31 Oct 2014, gyungoh@gmail.com wrote:
> Code looks fine, but what are its dependencies. I'm assuming nothing;
> however, did Mark say that something depends on it?

That would be REGULATOR_SKY81452. That is currently dangling (since
v3.18-rc1) as it depends on the non-existent symbol SKY81452.

> If so, what and what are you going to do about it?

See 7/8. That patch makes REGULATOR_SKY81452 depend on MFD_SKY81452,
making it buildable.

> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 1456ea7..a54244c 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -693,6 +693,18 @@ config MFD_SM501_GPIO
> > lines on the SM501. The platform data is used to supply the
> > base number for the first GPIO line to register.
> >
> > +config MFD_SKY81452
> > + tristate "Skyworks Solutions SKY81452"
> > + select MFD_CORE
> > + select REGMAP_I2C
> > + depends on I2C
> > + help
> > + This is the core driver for the Skyworks SKY81452 backlight and
> > + voltage regulator device.
> > +
> > + This driver can also be built as a module. If so, the module
> > + will be called sky81452.
> > +
> > config MFD_SMSC
> > bool "SMSC ECE1099 series chips"
> > depends on I2C=y

Paul Bolle