From: Gyungoh Yoo <gyungoh@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
jack.yoo@skyworksinc.com
Subject: Re: [PATCH] regulator: sky81452: Remove module version
Date: Wed, 8 Oct 2014 17:57:22 +0900 [thread overview]
Message-ID: <20141008085722.GC3362@jack-ThinkPad-T520> (raw)
In-Reply-To: <1412733463.8255.1.camel@phoenix>
On Wed, Oct 08, 2014 at 09:57:43AM +0800, Axel Lin wrote:
> The module version is unlikely to be updated, use kernel version should be
> enough.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Gyungoh,
> Seems you have added MODULE_VERSION for the sky81452 serial patches.
> Do you really need that and will keep updating it?
> Otherwise, you may want to drop the MODULE_VERSION in sky81452 serial patches.
I see.
I will remove MODULE_VERSION and resumit.
Thank you.
>
> drivers/regulator/sky81452-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/sky81452-regulator.c b/drivers/regulator/sky81452-regulator.c
> index 97aff0c..476b80a 100644
> --- a/drivers/regulator/sky81452-regulator.c
> +++ b/drivers/regulator/sky81452-regulator.c
> @@ -127,4 +127,3 @@ module_platform_driver(sky81452_reg_driver);
> MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver");
> MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0");
> --
> 1.9.1
>
>
>
next prev parent reply other threads:[~2014-10-08 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 1:57 [PATCH] regulator: sky81452: Remove module version Axel Lin
2014-10-08 8:57 ` Gyungoh Yoo [this message]
2014-10-08 11:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008085722.GC3362@jack-ThinkPad-T520 \
--to=gyungoh@gmail.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=jack.yoo@skyworksinc.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox