From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Daeseok Youn <daeseok.youn@gmail.com>,
devel@driverdev.osuosl.org, lidza.louina@gmail.com,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH V2] staging: dgap: introduce dgap_stop()
Date: Thu, 9 Oct 2014 13:23:41 +0300 [thread overview]
Message-ID: <20141009102341.GU23154@mwanda> (raw)
In-Reply-To: <20141009094902.GA4333@sudip-PC>
On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote:
> On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
> > The dgap_init_module() need to unwind for cleanup variables properly.
> > Because dgap_init_module() calls dgap_cleanup_module() for freeing
> > variables but this function is possible to free variables
> > which are not allocated.
> >
> > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> > ---
> > V2: change ulong which is non-standard to "unsigned long".
> I think , Dan, in his review of your v1 , asked you to rearrange the functions and get rid of the forward declarations.
>
I was fine with v1 actually... It's a bug fix, and this is staging and
there are tons of forward declarations already. Eventually we need to
get rid of them but it can be done later.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-09 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 4:40 [PATCH V2] staging: dgap: introduce dgap_stop() Daeseok Youn
2014-10-09 9:49 ` Sudip Mukherjee
2014-10-09 10:23 ` Dan Carpenter [this message]
2014-10-09 10:28 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009102341.GU23154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox