Re: [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products

Johan Hovold
2014-10-10T09:23:06Z

On Fri, Oct 10, 2014 at 11:12:09AM +0200, Frans Klaver wrote:
> On Fri, Oct 10, 2014 at 11:01:17AM +0200, Johan Hovold wrote:
> > On Fri, Oct 10, 2014 at 10:44:54AM +0200, Frans Klaver wrote:

> > > diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> > > index 5937b2d..be3fffe 100644
> > > --- a/drivers/usb/serial/ftdi_sio_ids.h
> > > +++ b/drivers/usb/serial/ftdi_sio_ids.h
> > > @@ -145,6 +145,8 @@
> > > #define XSENS_VID 0x2639
> > > #define XSENS_CONVERTER_PID 0xD00D /* Xsens USB-serial converter */
> > > #define XSENS_MTW_PID 0x0200 /* Xsens MTw */
> > > +#define XSENS_AWINDA_STATION_PID 0x0101
> > > +#define XSENS_AWINDA_DONGLE_PID 0x0102
> >
> > And sorted by PID here (even though the two current entries are not, you
> > could reorder them as well).
> >
> > I noticed that the below PIDs use the FTDI VID. Perhaps a comment or at
> > least a separating empty line would be appropriate.
> >
> > > #define XSENS_CONVERTER_0_PID 0xD388 /* Xsens USB converter */
> > > #define XSENS_CONVERTER_1_PID 0xD389 /* Xsens Wireless Receiver */
> > > #define XSENS_CONVERTER_2_PID 0xD38A
>
> I'll move the new entries up. How about I throw in a separate patch that
> cleans up stuff around the PID definitions? There's some alignment off
> as well. That doesn't need to go into stable, I think.

As long as you keep the clean up minimal (e.g. the reorder the two
entries above and add a comment or new line, skip the alignment bit) it
can all go in one patch along with the new PIDs.

That way there'll be no conflicts when future PID-patches get backported
to stable.

Thanks,
Johan