Re: [PATCH fixes 1/2] mfd: max77693: Use proper regmap for handling MUIC interrupts

Lee Jones
2014-10-10T08:55:30Z

On Fri, 10 Oct 2014, Krzysztof Kozlowski wrote:

> Interrupts coming from Maxim77693 MUIC block (MicroUSB Interface
> Controller) were not handled at all because wrong regmap was used for
> MUIC's regmap_irq_chip.
>
> The MUIC component of Maxim 77693 uses different I2C address thus second
> regmap is created and used by max77693 extcon driver. The registers for
> MUIC interrupts are also in that block and should be handled by that
> second regmap.
>
> However the regmap irq chip for MUIC was configured with default regmap
> which could not read MUIC registers.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 342d669c1ee4 ("mfd: max77693: Handle IRQs using regmap")
> ---
> drivers/mfd/max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to -fixes.

> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 2277a11b6629..4b54da1ff7ab 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -243,7 +243,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
> goto err_irq_charger;
> }
>
> - ret = regmap_add_irq_chip(max77693->regmap, max77693->irq,
> + ret = regmap_add_irq_chip(max77693->regmap_muic, max77693->irq,
> IRQF_ONESHOT | IRQF_SHARED |
> IRQF_TRIGGER_FALLING, 0,
> &max77693_muic_irq_chip,

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog