* nf_reject_ipv4: module license 'unspecified' taints kernel
@ 2014-10-10 9:19 Dave Young
2014-10-10 9:53 ` David Laight
2014-10-10 9:56 ` Pablo Neira Ayuso
0 siblings, 2 replies; 6+ messages in thread
From: Dave Young @ 2014-10-10 9:19 UTC (permalink / raw)
To: pablo; +Cc: davem, netdev, linux-kernel
Hi,
With today's linus tree, I got below kmsg:
[ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel.
[ 23.551886] Disabling lock debugging due to kernel taint
[ 23.557302] nf_reject_ipv4: Unknown symbol lock_is_held (err 0)
[ 23.563256] nf_reject_ipv4: Unknown symbol rcu_read_lock_bh_held (err 0)
[ 23.569992] nf_reject_ipv4: Unknown symbol ip_local_out_sk (err 0)
[ 23.576206] nf_reject_ipv4: Unknown symbol debug_lockdep_rcu_enabled (err 0)
[ 23.583290] nf_reject_ipv4: Unknown symbol rcu_is_watching (err 0)
[ 23.589523] nf_reject_ipv4: Unknown symbol rcu_lock_map (err
It could be caused by below commit:
commit c8d7b98bec43faaa6583c3135030be5eb4693acb
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Fri Sep 26 14:35:15 2014 +0200
netfilter: move nf_send_resetX() code to nf_reject_ipvX modules
Move nf_send_reset() and nf_send_reset6() to nf_reject_ipv4 and
nf_reject_ipv6 respectively. This code is shared by x_tables and
nf_tables.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
I believe there's similar issue for ipv6 reject part though I have disabled ipv6
in my .config.
Let me know if you need any furthur information.
Thanks
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: nf_reject_ipv4: module license 'unspecified' taints kernel 2014-10-10 9:19 nf_reject_ipv4: module license 'unspecified' taints kernel Dave Young @ 2014-10-10 9:53 ` David Laight 2014-10-14 8:12 ` 'Dave Young' 2014-10-10 9:56 ` Pablo Neira Ayuso 1 sibling, 1 reply; 6+ messages in thread From: David Laight @ 2014-10-10 9:53 UTC (permalink / raw) To: 'Dave Young', pablo@netfilter.org Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Dave Young > With today's linus tree, I got below kmsg: > [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. > [ 23.551886] Disabling lock debugging due to kernel taint ... Not 100% related, but why does loading a non-GPL module disable lock debugging? (Is 'lock debugging' actually useful?) David ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: nf_reject_ipv4: module license 'unspecified' taints kernel 2014-10-10 9:53 ` David Laight @ 2014-10-14 8:12 ` 'Dave Young' 0 siblings, 0 replies; 6+ messages in thread From: 'Dave Young' @ 2014-10-14 8:12 UTC (permalink / raw) To: David Laight Cc: pablo@netfilter.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org On 10/10/14 at 09:53am, David Laight wrote: > From: Dave Young > > With today's linus tree, I got below kmsg: > > [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. > > [ 23.551886] Disabling lock debugging due to kernel taint > ... > > Not 100% related, but why does loading a non-GPL module disable > lock debugging? > (Is 'lock debugging' actually useful?) I believe that we can not trust the debugging any more because kernel taint.. Thanks Dave ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: nf_reject_ipv4: module license 'unspecified' taints kernel 2014-10-10 9:19 nf_reject_ipv4: module license 'unspecified' taints kernel Dave Young 2014-10-10 9:53 ` David Laight @ 2014-10-10 9:56 ` Pablo Neira Ayuso 2014-10-14 8:11 ` Dave Young 1 sibling, 1 reply; 6+ messages in thread From: Pablo Neira Ayuso @ 2014-10-10 9:56 UTC (permalink / raw) To: Dave Young; +Cc: davem, netdev, linux-kernel, netfilter-devel [-- Attachment #1: Type: text/plain, Size: 828 bytes --] On Fri, Oct 10, 2014 at 05:19:04PM +0800, Dave Young wrote: > Hi, > > With today's linus tree, I got below kmsg: > [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. > > It could be caused by below commit: > > commit c8d7b98bec43faaa6583c3135030be5eb4693acb > Author: Pablo Neira Ayuso <pablo@netfilter.org> > Date: Fri Sep 26 14:35:15 2014 +0200 > > netfilter: move nf_send_resetX() code to nf_reject_ipvX modules > > Move nf_send_reset() and nf_send_reset6() to nf_reject_ipv4 and > nf_reject_ipv6 respectively. This code is shared by x_tables and > nf_tables. > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Patch attached, thanks for reporting. P.S: Please, Cc netfilter-devel@vger.kernel.org in future reports, so we make sure things don't get lost. [-- Attachment #2: 0001-netfilter-missing-module-license-in-the-nf_reject_ip.patch --] [-- Type: text/x-diff, Size: 1710 bytes --] >From d4358bcf64ba7a64d4de4e1dc5533c4c8f88ea82 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso <pablo@netfilter.org> Date: Fri, 10 Oct 2014 11:25:20 +0200 Subject: [PATCH] netfilter: missing module license in the nf_reject_ipvX modules [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. Reported-by: Dave Young <dyoung@redhat.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> --- net/ipv4/netfilter/nf_reject_ipv4.c | 3 +++ net/ipv6/netfilter/nf_reject_ipv6.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c index b023b4e..92b303d 100644 --- a/net/ipv4/netfilter/nf_reject_ipv4.c +++ b/net/ipv4/netfilter/nf_reject_ipv4.c @@ -6,6 +6,7 @@ * published by the Free Software Foundation. */ +#include <linux/module.h> #include <net/ip.h> #include <net/tcp.h> #include <net/route.h> @@ -125,3 +126,5 @@ void nf_send_reset(struct sk_buff *oldskb, int hook) kfree_skb(nskb); } EXPORT_SYMBOL_GPL(nf_send_reset); + +MODULE_LICENSE("GPL"); diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c index 5f5f043..20d9def 100644 --- a/net/ipv6/netfilter/nf_reject_ipv6.c +++ b/net/ipv6/netfilter/nf_reject_ipv6.c @@ -5,6 +5,8 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ + +#include <linux/module.h> #include <net/ipv6.h> #include <net/ip6_route.h> #include <net/ip6_fib.h> @@ -161,3 +163,5 @@ void nf_send_reset6(struct net *net, struct sk_buff *oldskb, int hook) ip6_local_out(nskb); } EXPORT_SYMBOL_GPL(nf_send_reset6); + +MODULE_LICENSE("GPL"); -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: nf_reject_ipv4: module license 'unspecified' taints kernel 2014-10-10 9:56 ` Pablo Neira Ayuso @ 2014-10-14 8:11 ` Dave Young 2014-10-29 21:05 ` Benjamin Tissoires 0 siblings, 1 reply; 6+ messages in thread From: Dave Young @ 2014-10-14 8:11 UTC (permalink / raw) To: Pablo Neira Ayuso; +Cc: davem, netdev, linux-kernel, netfilter-devel On 10/10/14 at 11:56am, Pablo Neira Ayuso wrote: > On Fri, Oct 10, 2014 at 05:19:04PM +0800, Dave Young wrote: > > Hi, > > > > With today's linus tree, I got below kmsg: > > [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. > > > > It could be caused by below commit: > > > > commit c8d7b98bec43faaa6583c3135030be5eb4693acb > > Author: Pablo Neira Ayuso <pablo@netfilter.org> > > Date: Fri Sep 26 14:35:15 2014 +0200 > > > > netfilter: move nf_send_resetX() code to nf_reject_ipvX modules > > > > Move nf_send_reset() and nf_send_reset6() to nf_reject_ipv4 and > > nf_reject_ipv6 respectively. This code is shared by x_tables and > > nf_tables. > > > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > > Patch attached, thanks for reporting. Tested-by: Dave Young <dyoung@redhat.com> > > P.S: Please, Cc netfilter-devel@vger.kernel.org in future reports, so > we make sure things don't get lost. Sure. Thanks. > From d4358bcf64ba7a64d4de4e1dc5533c4c8f88ea82 Mon Sep 17 00:00:00 2001 > From: Pablo Neira Ayuso <pablo@netfilter.org> > Date: Fri, 10 Oct 2014 11:25:20 +0200 > Subject: [PATCH] netfilter: missing module license in the nf_reject_ipvX > modules > > [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. > > Reported-by: Dave Young <dyoung@redhat.com> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > --- > net/ipv4/netfilter/nf_reject_ipv4.c | 3 +++ > net/ipv6/netfilter/nf_reject_ipv6.c | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c > index b023b4e..92b303d 100644 > --- a/net/ipv4/netfilter/nf_reject_ipv4.c > +++ b/net/ipv4/netfilter/nf_reject_ipv4.c > @@ -6,6 +6,7 @@ > * published by the Free Software Foundation. > */ > > +#include <linux/module.h> > #include <net/ip.h> > #include <net/tcp.h> > #include <net/route.h> > @@ -125,3 +126,5 @@ void nf_send_reset(struct sk_buff *oldskb, int hook) > kfree_skb(nskb); > } > EXPORT_SYMBOL_GPL(nf_send_reset); > + > +MODULE_LICENSE("GPL"); > diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c > index 5f5f043..20d9def 100644 > --- a/net/ipv6/netfilter/nf_reject_ipv6.c > +++ b/net/ipv6/netfilter/nf_reject_ipv6.c > @@ -5,6 +5,8 @@ > * it under the terms of the GNU General Public License version 2 as > * published by the Free Software Foundation. > */ > + > +#include <linux/module.h> > #include <net/ipv6.h> > #include <net/ip6_route.h> > #include <net/ip6_fib.h> > @@ -161,3 +163,5 @@ void nf_send_reset6(struct net *net, struct sk_buff *oldskb, int hook) > ip6_local_out(nskb); > } > EXPORT_SYMBOL_GPL(nf_send_reset6); > + > +MODULE_LICENSE("GPL"); > -- > 1.7.10.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: nf_reject_ipv4: module license 'unspecified' taints kernel 2014-10-14 8:11 ` Dave Young @ 2014-10-29 21:05 ` Benjamin Tissoires 0 siblings, 0 replies; 6+ messages in thread From: Benjamin Tissoires @ 2014-10-29 21:05 UTC (permalink / raw) To: Pablo Neira Ayuso Cc: Dave Young, davem, netdev, linux-kernel@vger.kernel.org, netfilter-devel On Tue, Oct 14, 2014 at 4:11 AM, Dave Young <dyoung@redhat.com> wrote: > On 10/10/14 at 11:56am, Pablo Neira Ayuso wrote: >> On Fri, Oct 10, 2014 at 05:19:04PM +0800, Dave Young wrote: >> > Hi, >> > >> > With today's linus tree, I got below kmsg: >> > [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. >> > >> > It could be caused by below commit: >> > >> > commit c8d7b98bec43faaa6583c3135030be5eb4693acb >> > Author: Pablo Neira Ayuso <pablo@netfilter.org> >> > Date: Fri Sep 26 14:35:15 2014 +0200 >> > >> > netfilter: move nf_send_resetX() code to nf_reject_ipvX modules >> > >> > Move nf_send_reset() and nf_send_reset6() to nf_reject_ipv4 and >> > nf_reject_ipv6 respectively. This code is shared by x_tables and >> > nf_tables. >> > >> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> >> >> Patch attached, thanks for reporting. > > Tested-by: Dave Young <dyoung@redhat.com> > >> >> P.S: Please, Cc netfilter-devel@vger.kernel.org in future reports, so >> we make sure things don't get lost. > > Sure. Thanks. > >> From d4358bcf64ba7a64d4de4e1dc5533c4c8f88ea82 Mon Sep 17 00:00:00 2001 >> From: Pablo Neira Ayuso <pablo@netfilter.org> >> Date: Fri, 10 Oct 2014 11:25:20 +0200 >> Subject: [PATCH] netfilter: missing module license in the nf_reject_ipvX >> modules >> >> [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. >> >> Reported-by: Dave Young <dyoung@redhat.com> >> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> >> --- Hi, What is the status of this patch? I can not find it in Pablo's trees (or I did not look enough). Not having it is actually bothering me quite a lot because the vanilla v3.18-rc2 gives the following dmesg on Fedora 21: Oct 29 16:50:01 t440s kernel: nf_reject_ipv6: module license 'unspecified' taints kernel. Oct 29 16:50:01 t440s kernel: Disabling lock debugging due to kernel taint Oct 29 16:50:01 t440s kernel: nf_reject_ipv6: Unknown symbol ip6_local_out (err 0) And unfortunately, firewalld failed after, and I can not directly ssh to the host. Now that I found the solution, my process improved a lot (thank you BTW for whoever included it in Fedora), but I guess other distributions might hit the problem. I would say such a trivial patch could easily go in one of the v3.18 RCs. Cheers, Benjamin >> net/ipv4/netfilter/nf_reject_ipv4.c | 3 +++ >> net/ipv6/netfilter/nf_reject_ipv6.c | 4 ++++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c >> index b023b4e..92b303d 100644 >> --- a/net/ipv4/netfilter/nf_reject_ipv4.c >> +++ b/net/ipv4/netfilter/nf_reject_ipv4.c >> @@ -6,6 +6,7 @@ >> * published by the Free Software Foundation. >> */ >> >> +#include <linux/module.h> >> #include <net/ip.h> >> #include <net/tcp.h> >> #include <net/route.h> >> @@ -125,3 +126,5 @@ void nf_send_reset(struct sk_buff *oldskb, int hook) >> kfree_skb(nskb); >> } >> EXPORT_SYMBOL_GPL(nf_send_reset); >> + >> +MODULE_LICENSE("GPL"); >> diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c >> index 5f5f043..20d9def 100644 >> --- a/net/ipv6/netfilter/nf_reject_ipv6.c >> +++ b/net/ipv6/netfilter/nf_reject_ipv6.c >> @@ -5,6 +5,8 @@ >> * it under the terms of the GNU General Public License version 2 as >> * published by the Free Software Foundation. >> */ >> + >> +#include <linux/module.h> >> #include <net/ipv6.h> >> #include <net/ip6_route.h> >> #include <net/ip6_fib.h> >> @@ -161,3 +163,5 @@ void nf_send_reset6(struct net *net, struct sk_buff *oldskb, int hook) >> ip6_local_out(nskb); >> } >> EXPORT_SYMBOL_GPL(nf_send_reset6); >> + >> +MODULE_LICENSE("GPL"); >> -- >> 1.7.10.4 >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-29 21:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-10-10 9:19 nf_reject_ipv4: module license 'unspecified' taints kernel Dave Young 2014-10-10 9:53 ` David Laight 2014-10-14 8:12 ` 'Dave Young' 2014-10-10 9:56 ` Pablo Neira Ayuso 2014-10-14 8:11 ` Dave Young 2014-10-29 21:05 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).