From: Lee Jones <lee.jones@linaro.org>
To: micky_ching@realsil.com.cn
Cc: sameo@linux.intel.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
rogerable@realtek.com, wei_wang@realsil.com.cn
Subject: Re: [PATCH v2] mfd: rtsx: fix PM suspend for 5227 & 5249
Date: Fri, 10 Oct 2014 11:21:04 +0100 [thread overview]
Message-ID: <20141010102104.GK26795@lee--X1> (raw)
In-Reply-To: <1412920724-27945-1-git-send-email-micky_ching@realsil.com.cn>
On Fri, 10 Oct 2014, micky_ching@realsil.com.cn wrote:
> From: Micky Ching <micky_ching@realsil.com.cn>
>
> Fix rts5227&5249 failed send buffer cmd after suspend,
> PM_CTRL3 should reset before send any buffer cmd after suspend.
> Otherwise, buffer cmd will failed, this will lead resume fail.
>
> Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
> ---
> drivers/mfd/Makefile | 2 +-
> drivers/mfd/rts5227.c | 6 ++++++
> drivers/mfd/rts5249.c | 4 ++++
> drivers/mfd/rtsx_gops.c | 37 +++++++++++++++++++++++++++++++++++++
> drivers/mfd/rtsx_pcr.h | 3 +++
> include/linux/mfd/rtsx_pci.h | 28 ++++++++++++++++++++++++++++
> 6 files changed, 79 insertions(+), 1 deletion(-)
> create mode 100644 drivers/mfd/rtsx_gops.c
[...]
> +static inline int rtsx_pci_update_cfg_byte(struct rtsx_pcr *pcr, int addr,
> + u8 mask, u8 append)
> +{
> + int err;
> + u8 val;
> +
> + err = pci_read_config_byte(pcr->pci, addr, &val);
> + if (err < 0)
> + return err;
> + return pci_write_config_byte(pcr->pci, addr, (val & mask) | append);
> +}
> +
Why is this in here? Why not put it in the generic ops file?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-10-10 10:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 5:58 [PATCH v2] mfd: rtsx: fix PM suspend for 5227 & 5249 micky_ching
2014-10-10 9:24 ` Lee Jones
2014-10-10 9:29 ` Micky Ching
2014-10-10 10:21 ` Lee Jones [this message]
2014-10-11 1:07 ` Micky Ching
2014-10-22 8:45 ` Micky Ching
2014-10-22 9:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010102104.GK26795@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox