From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbaJJHLo (ORCPT ); Fri, 10 Oct 2014 03:11:44 -0400 Received: from ygrex.ru ([5.19.241.250]:48552 "EHLO ygrex.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbaJJHLl (ORCPT ); Fri, 10 Oct 2014 03:11:41 -0400 Date: Fri, 10 Oct 2014 11:09:20 +0400 From: Igor Bogomazov To: devel@driverdev.osuosl.org Cc: trivial@kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell , navin patidar , Greg Kroah-Hartman Subject: [PATCH] staging: rtl8188eu: coding style fixup Message-ID: <20141010110920.18d90eee@ygrex-lenovo> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org checkpatch.pl tiny fix get rid of 2 warnings and 2 errors for hal/fw.c: WARNING: braces {} are not necessary for single statement blocks WARNING: line over 80 characters ERROR: space required before the open brace '{' ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Igor Bogomazov Cc: Greg Kroah-Hartman Cc: navin patidar Cc: Stephen Rothwell --- for linux-next 3.17.0 this is an updated version of the patch I've sent yesterday, that one did not provide a clear description diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c --- a/drivers/staging/rtl8188eu/hal/fw.c +++ b/drivers/staging/rtl8188eu/hal/fw.c @@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt) break; } while (counter++ < POLLING_READY_TIMEOUT_COUNT); - if (counter >= POLLING_READY_TIMEOUT_COUNT) { + if (counter >= POLLING_READY_TIMEOUT_COUNT) goto exit; - } value32 = usb_read32(adapt, REG_MCUFWDL); value32 |= MCUFWDL_RDY; @@ -193,13 +192,13 @@ int rtl88eu_download_fw(struct adapter *adapt) u32 fwsize; int err; - if (request_firmware(&fw, fw_name, device)){ + if (request_firmware(&fw, fw_name, device)) { dev_err(device, "Firmware %s not available\n", fw_name); return -ENOENT; } if (fw->size > FW_8188E_SIZE) { - dev_err(device,"Firmware size exceed 0x%X. Check it.\n", + dev_err(device, "Firmware size exceed 0x%X. Check it.\n", FW_8188E_SIZE); return -1; } @@ -226,7 +225,8 @@ int rtl88eu_download_fw(struct adapter *adapt) rtl88e_firmware_selfreset(adapt); } _rtl88e_enable_fw_download(adapt, true); - usb_write8(adapt, REG_MCUFWDL, usb_read8(adapt, REG_MCUFWDL) | FWDL_ChkSum_rpt); + usb_write8(adapt, REG_MCUFWDL, + usb_read8(adapt, REG_MCUFWDL) | FWDL_ChkSum_rpt); _rtl88e_write_fw(adapt, pfwdata, fwsize); _rtl88e_enable_fw_download(adapt, false);