Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB Serial Bridge controller

[Lee Jones <lee.jones@linaro.org>]

> > -----Original Message-----
> > From: Lee Jones [mailto:lee.jones@linaro.org]
> > Sent: Thursday, October 09, 2014 1:10 PM
> > To: Muthu Mani
> > Cc: Samuel Ortiz; Wolfram Sang; Linus Walleij; Alexandre Courbot;
> > gregkh@linuxfoundation.org; linux-i2c@vger.kernel.org; linux-
> > gpio@vger.kernel.org; linux-usb@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Rajaram Regupathy; Johan Hovold
> > Subject: Re: [PATCH v3 1/3] mfd: add support for Cypress CYUSBS234 USB
> > Serial Bridge controller

Why is this in here?

> > > +     cyusbs->usb_dev = usb_get_dev(interface_to_usbdev(interface));
> > 
> > Can you do this last?  Then you can remove the 'error' error path.
> 
> mfd_add_devices would utlimately invoke the cell drivers' probe before returning and cell drivers use usb_dev in their probe.
> So, leaving it as such.

Can you move it down to just about mfd_add_devices() then.  That way
can you at least return directly in the other error paths.

[...]

> > > +MODULE_AUTHOR("Rajaram Regupathy <rera@cypress.com>");
> > > +MODULE_AUTHOR("Muthu Mani <muth@cypress.com>");
> > > +MODULE_DESCRIPTION("Cypress CYUSBS23x mfd core driver");
> > 
> > s/mfd/MFD/
> 
> Is there a typo?

Yes mfd should be MFD, as I sed (spelt this way on purpose).

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog