From: Guenter Roeck <linux@roeck-us.net>
To: Mark D Rustad <mrustad@gmail.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Torsten Duwe <duwe@lst.de>, "Theodore Ts'o" <tytso@mit.edu>,
Jason Cooper <jason@lakedaemon.net>,
Amit Shah <amit.shah@redhat.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Kees Cook <keescook@chromium.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy
Date: Sat, 11 Oct 2014 19:25:18 -0700 [thread overview]
Message-ID: <20141012022518.GA29109@roeck-us.net> (raw)
In-Reply-To: <20141012021122.GA10822@roeck-us.net>
On Sat, Oct 11, 2014 at 07:11:22PM -0700, Guenter Roeck wrote:
> On Sat, Oct 11, 2014 at 05:27:41PM -0700, Mark D Rustad wrote:
> > On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote:
> >
> > > Changed from using strncpy to strlcpy to simplify the code
> >
> > Actually you changed from using strncat to strlcat.
> >
> ... and changed the length parameter along the way, making the length check
> overall quite worthless and introducing a _real_ problem.
>
Me talking nonsense; ignore this noise.
Guenter
next prev parent reply other threads:[~2014-10-12 2:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 22:36 [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy Rickard Strandqvist
2014-10-12 0:27 ` Mark D Rustad
2014-10-12 2:11 ` Guenter Roeck
2014-10-12 2:25 ` Guenter Roeck [this message]
2014-10-12 10:32 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012022518.GA29109@roeck-us.net \
--to=linux@roeck-us.net \
--cc=amit.shah@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=duwe@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=mrustad@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=sboyd@codeaurora.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox