From: Peter Zijlstra <peterz@infradead.org>
To: riel@redhat.com
Cc: linux-kernel@vger.kernel.org, mgorman@suse.de,
chegu_vinod@hp.com, mingo@kernel.org, efault@gmx.de,
vincent.guittot@linaro.org
Subject: Re: [PATCH RFC 2/5] sched,numa: classify the NUMA topology of a system
Date: Sun, 12 Oct 2014 16:30:56 +0200 [thread overview]
Message-ID: <20141012143056.GF3015@worktop> (raw)
In-Reply-To: <1412797050-8903-3-git-send-email-riel@redhat.com>
On Wed, Oct 08, 2014 at 03:37:27PM -0400, riel@redhat.com wrote:
> +static void init_numa_topology_type(void)
> +{
> + int a, b, c, n;
> +
> + n = sched_domains_numa_levels;
> +
> + if (n <= 1)
> + sched_numa_topology_type = NUMA_DIRECT;
> +
> + for_each_online_node(a) {
> + for_each_online_node(b) {
> + /* Find two nodes furthest removed from each other. */
> + if (node_hops(a, b) < n)
> + continue;
> +
> + /* Is there an intermediary node between a and b? */
> + for_each_online_node(c) {
> + if (node_hops(a, c) < n &&
> + node_hops(b, c) < n) {
> + sched_numa_topology_type =
> + NUMA_GLUELESS_MESH;
> + return;
> + }
> + }
> +
> + sched_numa_topology_type = NUMA_BACKPLANE;
> + return;
> + }
> + }
> +}
We can find max_distance nodes in sched_init_numa(), right? Could we not
avoid this second iteration?
next prev parent reply other threads:[~2014-10-12 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 19:37 [PATCH RFC 0/5] sched,numa: task placement with complex NUMA topologies riel
2014-10-08 19:37 ` [PATCH RFC 1/5] sched,numa: build table of node hop distance riel
2014-10-12 13:17 ` Peter Zijlstra
2014-10-12 13:28 ` Rik van Riel
2014-10-14 6:47 ` Peter Zijlstra
2014-10-14 7:49 ` Rik van Riel
2014-10-08 19:37 ` [PATCH RFC 2/5] sched,numa: classify the NUMA topology of a system riel
2014-10-12 14:30 ` Peter Zijlstra [this message]
2014-10-13 7:12 ` Rik van Riel
2014-10-08 19:37 ` [PATCH RFC 3/5] sched,numa: preparations for complex topology placement riel
2014-10-12 14:37 ` Peter Zijlstra
2014-10-13 7:12 ` Rik van Riel
2014-10-08 19:37 ` [PATCH RFC 4/5] sched,numa: calculate node scores in complex NUMA topologies riel
2014-10-12 14:53 ` Peter Zijlstra
2014-10-13 7:15 ` Rik van Riel
2014-10-08 19:37 ` [PATCH RFC 5/5] sched,numa: find the preferred nid with complex NUMA topology riel
2014-10-12 14:56 ` Peter Zijlstra
2014-10-13 7:17 ` Rik van Riel
[not found] ` <4168C988EBDF2141B4E0B6475B6A73D126F58E4F@G6W2504.americas.hpqcorp.net>
[not found] ` <54367446.3020603@redhat.com>
2014-10-10 18:44 ` [PATCH RFC 0/5] sched,numa: task placement with complex NUMA topologies Vinod, Chegu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012143056.GF3015@worktop \
--to=peterz@infradead.org \
--cc=chegu_vinod@hp.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox