From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Matthew Garrett <mjg59@srcf.ucam.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] dell-wmi: Fix access out of memory
Date: Sun, 12 Oct 2014 18:45:06 +0200 [thread overview]
Message-ID: <201410121845.07303@pali> (raw)
In-Reply-To: <55C20A75-AB0A-4A4E-9E91-3428B5F868BB@infradead.org>
[-- Attachment #1: Type: Text/Plain, Size: 928 bytes --]
On Tuesday 30 September 2014 01:16:23 Darren Hart wrote:
> On September 29, 2014 4:26:03 PM PDT, "Rafael J. Wysocki"
<rjw@rjwysocki.net> wrote:
> >On Monday, September 29, 2014 02:30:29 PM Darren Hart wrote:
> >> On Mon, Sep 29, 2014 at 03:10:51PM +0200, Pali Rohár wrote:
> >> > Without this patch driver dell-wmi is trying to access
> >> > elements of
> >
> >dynamically
> >
> >> > allocated array without checking array size. This can
> >> > lead to
> >
> >memory corruption
> >
> >> > or kernel panic. This patch adds missing checks for array
> >> > size.
> >> >
> >> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> >>
> >> Looks good to me. Rafael, any concerns?
> >
> >Not anything obvious.
>
> Queued, thanks.
>
> >> Cc: linux-acpi
> >
> >Thanks!
> >
Now I see that this patch is in linus tree. Can you sent it to
stable trees too?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-10-12 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 13:10 [PATCH] dell-wmi: Fix access out of memory Pali Rohár
2014-09-29 21:30 ` Darren Hart
2014-09-29 23:26 ` Rafael J. Wysocki
2014-09-29 23:16 ` Darren Hart
2014-10-12 16:45 ` Pali Rohár [this message]
2014-10-12 22:32 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410121845.07303@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).