From: Greg KH <gregkh@linuxfoundation.org>
To: Jonas Brunsgaard <jonas.brunsgaard@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: atm: fix style issues
Date: Mon, 13 Oct 2014 03:32:53 +0200 [thread overview]
Message-ID: <20141013013253.GC12633@kroah.com> (raw)
In-Reply-To: <1413063654-35070-1-git-send-email-jonas.brunsgaard@gmail.com>
On Sat, Oct 11, 2014 at 11:40:54PM +0200, Jonas Brunsgaard wrote:
> Signed-off-by: Jonas Brunsgaard <jonas.brunsgaard@gmail.com>
_what_ "style" issues did you fix?
How did you fix them?
Why did you fix them?
Please, you have to provide something in the changelog here, it can't
just be blank.
Also, make sure you aren't doing more than one thing in a single patch.
And no, you can't just claim "fix all style issues" is one thing, when
you do different types of style fixes.
care to try this again?
thanks,
greg k-h
next prev parent reply other threads:[~2014-10-13 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 16:02 [PATCH] usb: atm: fix codestyle issues in Jonas Brunsgaard
2014-10-11 17:00 ` Lars Melin
2014-10-11 17:08 ` Joe Perches
2014-10-11 17:28 ` Jonas Brunsgaard
2014-10-11 17:41 ` Lars Melin
2014-10-11 20:17 ` Greg KH
2014-10-11 22:35 ` Jonas Brunsgaard
2014-10-11 21:40 ` [PATCH v2] usb: atm: fix style issues Jonas Brunsgaard
2014-10-13 1:32 ` Greg KH [this message]
2014-10-13 16:08 ` Jonas Brunsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013013253.GC12633@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jonas.brunsgaard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).