public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, eparis@redhat.com,
	sgrubb@redhat.com, aviro@redhat.com, pmoore@redhat.com,
	arozansk@redhat.com, ebiederm@xmission.com, serge@hallyn.com
Subject: Re: [PATCH V5 07/13] audit: dump namespace IDs for pid on receipt of AUDIT_NS_INFO
Date: Mon, 13 Oct 2014 14:30:01 +0200	[thread overview]
Message-ID: <20141013123001.GE24703@mail.hallyn.com> (raw)
In-Reply-To: <2503a41768e92791f9901e8ee7c132634821a2db.1412543112.git.rgb@redhat.com>

Quoting Richard Guy Briggs (rgb@redhat.com):
> When a task with CAP_AUDIT_CONTROL sends a NETLINK_AUDIT message of type
> AUDIT_NS_INFO with a PID of interest, dump the namespace IDs of that task to
> the audit log.
> ---

Acked-by: Serge Hallyn <serge.hallyn@canonical.com>

>  kernel/audit.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c
> index a17a09f..cc63445 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -671,6 +671,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
>  	case AUDIT_TTY_SET:
>  	case AUDIT_TRIM:
>  	case AUDIT_MAKE_EQUIV:
> +	case AUDIT_NS_INFO:
>  		/* Only support auditd and auditctl in initial pid namespace
>  		 * for now. */
>  		if ((task_active_pid_ns(current) != &init_pid_ns))
> @@ -1068,6 +1069,19 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  		audit_log_end(ab);
>  		break;
>  	}
> +	case AUDIT_NS_INFO:
> +#ifdef CONFIG_NAMESPACES
> +	{
> +		struct task_struct *tsk;
> +
> +		rcu_read_lock();
> +		tsk = find_task_by_vpid(*(pid_t *)data);
> +		rcu_read_unlock();
> +		audit_log_ns_info(tsk);
> +	}
> +#else /* CONFIG_NAMESPACES */
> +		err = -EOPNOTSUPP;
> +#endif /* CONFIG_NAMESPACES */
>  	default:
>  		err = -EINVAL;
>  		break;
> -- 
> 1.7.1

  reply	other threads:[~2014-10-13 12:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06  5:08 [PATCH V5 00/13] namespaces: log namespaces per task Richard Guy Briggs
2014-10-06  5:08 ` [PATCH V5 01/13] namespaces: assign each namespace instance a serial number Richard Guy Briggs
2014-10-06  9:16   ` Chen, Hanxiao
2014-10-06 12:46     ` Richard Guy Briggs
2014-10-13 10:30   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 02/13] namespaces: expose namespace instance serial number in proc_ns_operations Richard Guy Briggs
2014-10-13 10:32   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 03/13] namespaces: expose ns_entries Richard Guy Briggs
2014-10-13 10:33   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 04/13] audit: log namespace serial numbers Richard Guy Briggs
2014-10-06  5:08 ` [PATCH V5 05/13] audit: initialize at subsystem time rather than device time Richard Guy Briggs
2014-10-13 12:30   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 06/13] audit: log creation and deletion of namespace instances Richard Guy Briggs
2014-10-13 12:26   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 07/13] audit: dump namespace IDs for pid on receipt of AUDIT_NS_INFO Richard Guy Briggs
2014-10-13 12:30   ` Serge E. Hallyn [this message]
2014-10-06  5:08 ` [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags Richard Guy Briggs
2014-10-06  9:21   ` Chen, Hanxiao
2014-10-06 12:47     ` Richard Guy Briggs
2014-10-13 13:15   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 09/13] fork: audit on creation of new namespace(s) Richard Guy Briggs
2014-10-13 13:14   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 10/13] audit: log on switching namespace (setns) Richard Guy Briggs
2014-10-13 13:22   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 11/13] audit: emit AUDIT_NS_INFO record with AUDIT_VIRT_CONTROL record Richard Guy Briggs
2014-10-13 13:34   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 12/13] namespaces: expose ns instance serial numbers in proc Richard Guy Briggs
2014-10-13 13:41   ` Serge E. Hallyn
2014-10-06  5:08 ` [PATCH V5 13/13] Documentation: add a section for /proc/<pid>/ns/ Richard Guy Briggs
2014-10-13 13:46   ` Serge E. Hallyn
2014-10-14 14:25     ` Richard Guy Briggs
2014-10-14 22:03     ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141013123001.GE24703@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=arozansk@redhat.com \
    --cc=aviro@redhat.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmoore@redhat.com \
    --cc=rgb@redhat.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox