From: Mark Brown <broonie@kernel.org>
To: Kiran Padwal <kiran.padwal@smartplayin.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/3] spi: qup: Remove .owner field for driver
Date: Tue, 14 Oct 2014 10:09:56 +0200 [thread overview]
Message-ID: <20141014080956.GQ27755@sirena.org.uk> (raw)
In-Reply-To: <543CC015.6090709@smartplayin.com>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On Tue, Oct 14, 2014 at 11:47:57AM +0530, Kiran Padwal wrote:
> On Monday 13 October 2014 06:39 PM, Mark Brown wrote:
> > Two problems:
> > - I'm missing patches 1 and 2.
> These patches are same like this one,
> [1] https://lkml.org/lkml/2014/10/9/58
> [2] https://lkml.org/lkml/2014/10/9/52
You should at least be sending the cover letter to everyone so that they
know what's going on.
> > - This only changes one driver but essentially every SPI driver
> > initializes .owner - why is only thi sone driver being changed?
> Nothing more intention, but just remove superfluous .owner field for drivers which
> use the module_platform_driver API, as this is overridden in
> platform_driver_register anyway.
My point is that doing a change like this to random drivers isn't great,
if you're going to do this sort of thing it is better to do it for
everything rather than making things inconsistent.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-14 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 7:42 [PATCH 3/3] spi: qup: Remove .owner field for driver Kiran Padwal
2014-10-13 13:09 ` Mark Brown
2014-10-14 6:17 ` Kiran Padwal
2014-10-14 8:09 ` Mark Brown [this message]
2014-10-14 9:01 ` Kiran Padwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014080956.GQ27755@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kiran.padwal@smartplayin.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox