From: Richard Cochran <richardcochran@gmail.com>
To: Mike Surcouf <mps.surcouf.lkml@gmail.com>
Cc: Thomas Shao <huishao@microsoft.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
KY Srinivasan <kys@microsoft.com>
Subject: Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample
Date: Tue, 14 Oct 2014 16:21:38 +0200 [thread overview]
Message-ID: <20141014142138.GA6469@localhost.localdomain> (raw)
In-Reply-To: <CAL7Bo8ESE-=FY0KyQDc2Ne1SfX=fF0Q088jo_j-JpMmQYvArGg@mail.gmail.com>
On Tue, Oct 14, 2014 at 02:16:34PM +0100, Mike Surcouf wrote:
> What is your expected value for TICK_USEC? I cant make the arithmetic work.
> You double the check time if you are close but you never reduce the
> check time if you are not.
> Adjusting the tick count is a coarse adjustment of the clock. You
> will end up chasing the host time but never stabilizing it.
We should not be putting hardcoded servos into random drivers.
Instead, why not export the time offset to the guest as a series of
PPS samples, or the like? Then, a user space program in the guest can
decide whether it will use the information and how to filter the
signal.
> Regarding the comment we have NTP for this I agree that would be
> better than this implementation and I think Thomas agrees (as he said
> NTP is the preferred option)
> In order for this to be a good source of time for RTP and other time
> sensitive stuff . you will have to have to re-implement parts of NTP
> such as adjusting the clock frequency decreasing the check period when
> error becomes too great etc. etc..
No, lets not re-implement NTP. That would be a waste of effort.
Thanks,
Richard
next prev parent reply other threads:[~2014-10-14 14:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 11:11 [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample Thomas Shao
2014-10-14 11:19 ` Dan Carpenter
2014-10-14 12:50 ` Thomas Shao
2014-10-14 13:10 ` Dan Carpenter
2014-10-14 13:13 ` Thomas Shao
2014-10-14 13:16 ` Mike Surcouf
2014-10-14 14:00 ` Thomas Shao
2014-10-14 16:46 ` Mike Surcouf
2014-10-14 14:21 ` Richard Cochran [this message]
2014-10-14 13:43 ` Joe Perches
2014-10-14 11:54 ` Richard Cochran
2014-10-14 13:04 ` Thomas Shao
2014-10-14 13:19 ` Richard Cochran
2014-10-14 14:08 ` Thomas Shao
2014-10-14 13:25 ` Richard Cochran
2014-10-14 14:12 ` Thomas Shao
2014-10-14 14:14 ` Mike Surcouf
2014-10-14 14:33 ` Richard Cochran
2014-10-14 15:00 ` Victor Miasnikov
2014-10-14 16:30 ` Richard Cochran
2014-10-14 14:25 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014142138.GA6469@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=huishao@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mps.surcouf.lkml@gmail.com \
--cc=olaf@aepfle.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox