public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Mike Surcouf <mps.surcouf.lkml@gmail.com>
Cc: Thomas Shao <huishao@microsoft.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"olaf@aepfle.de" <olaf@aepfle.de>,
	"apw@canonical.com" <apw@canonical.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	KY Srinivasan <kys@microsoft.com>
Subject: Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample
Date: Tue, 14 Oct 2014 16:33:46 +0200	[thread overview]
Message-ID: <20141014143346.GC6469@localhost.localdomain> (raw)
In-Reply-To: <CAL7Bo8EHOgBFtE87ecC9PSwUy2=M5Q31ka6BX2Eut-eqXSbang@mail.gmail.com>

On Tue, Oct 14, 2014 at 03:14:21PM +0100, Mike Surcouf wrote:
> Even with networking I think there are other senarios where this would
> be useful such as no access to an NTP server  due to firewall rules or
> no internal NTP or simply an admin without much knowledge of NTP.

Perhaps, but ...

> HyperV host very likely has good time from AD and it would be good if
> the Linux VM just synced its time from the host after a vanilla
> install  (just like windows VMs).

Just cause windows does it, doesn't make it a good idea.

> That would require no configuration and probably save a ton of support traffic.
> However this patch requires a module parameter which really negates
> the zero configuration argument.
> Also please don't make this the default until the timesync component
> is more comprehensive and provides a stable time of similar quality to
> NTP.

We really don't want to go there.

> VMware has put a lot of effort into host -> guest timesync so I think
> there is a case for some form of host based time sync on HyperV.

Again, that is fine for VMware, but it might not be the best way.

IMHO, you should let the guest steer its own clock. That gives the end
user the most flexibility. Just provide the offset information, and
let a dedicated service (like ntpd or linuxptp's phc2sys) do the rest.

Thanks,
Richard

  reply	other threads:[~2014-10-14 14:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 11:11 [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample Thomas Shao
2014-10-14 11:19 ` Dan Carpenter
2014-10-14 12:50   ` Thomas Shao
2014-10-14 13:10     ` Dan Carpenter
2014-10-14 13:13       ` Thomas Shao
2014-10-14 13:16     ` Mike Surcouf
2014-10-14 14:00       ` Thomas Shao
2014-10-14 16:46         ` Mike Surcouf
2014-10-14 14:21       ` Richard Cochran
2014-10-14 13:43   ` Joe Perches
2014-10-14 11:54 ` Richard Cochran
2014-10-14 13:04   ` Thomas Shao
2014-10-14 13:19     ` Richard Cochran
2014-10-14 14:08       ` Thomas Shao
2014-10-14 13:25     ` Richard Cochran
2014-10-14 14:12       ` Thomas Shao
2014-10-14 14:14       ` Mike Surcouf
2014-10-14 14:33         ` Richard Cochran [this message]
2014-10-14 15:00           ` Victor Miasnikov
2014-10-14 16:30           ` Richard Cochran
2014-10-14 14:25 ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141014143346.GC6469@localhost.localdomain \
    --to=richardcochran@gmail.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=huishao@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mps.surcouf.lkml@gmail.com \
    --cc=olaf@aepfle.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox