From: Felipe Balbi <balbi@ti.com>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: be more verbose on ERRATIC_ERROR interrupt
Date: Wed, 15 Oct 2014 00:00:22 -0500 [thread overview]
Message-ID: <20141015050022.GA2378@saruman> (raw)
In-Reply-To: <1413317705-10194-1-git-send-email-david.a.cohen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
Hi,
On Tue, Oct 14, 2014 at 01:15:05PM -0700, David Cohen wrote:
> ERRATIC_ERROR interrupt is an event that needs more attention from
> developers than currently implemented, since this indicates a serious
> stability issue. The only way to get warned about it is by selecting the
> maximum driver's verbosity.
>
> This patch increases a bit the error's verbosity.
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
> drivers/usb/dwc3/gadget.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 3818b26bfc05..132e761d62e4 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -2484,7 +2484,8 @@ static void dwc3_gadget_interrupt(struct dwc3 *dwc,
> dev_vdbg(dwc->dev, "Start of Periodic Frame\n");
> break;
> case DWC3_DEVICE_EVENT_ERRATIC_ERROR:
> - dev_vdbg(dwc->dev, "Erratic Error\n");
> + WARN_ON_ONCE(1);
> + dev_dbg(dwc->dev, "Erratic Error\n");
how about:
WARN_ONCE(true, "Erratic Error\n");
instead ?
> break;
> case DWC3_DEVICE_EVENT_CMD_CMPL:
> dev_vdbg(dwc->dev, "Command Complete\n");
> --
> 2.1.0
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-15 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 20:15 [PATCH] usb: dwc3: be more verbose on ERRATIC_ERROR interrupt David Cohen
2014-10-15 5:00 ` Felipe Balbi [this message]
2014-10-15 16:57 ` David Cohen
2014-10-15 17:01 ` David Cohen
2014-10-15 17:06 ` Felipe Balbi
2014-10-15 18:36 ` David Cohen
2014-10-15 18:55 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015050022.GA2378@saruman \
--to=balbi@ti.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox