From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings
Date: Wed, 15 Oct 2014 15:34:31 +0300 [thread overview]
Message-ID: <20141015123431.GA23154@mwanda> (raw)
In-Reply-To: <1413375999-10210-1-git-send-email-jeffrey.t.kirsher@intel.com>
On Wed, Oct 15, 2014 at 05:26:39AM -0700, Jeff Kirsher wrote:
> The Beceem WIMAX was generating compile warnings on 64bit machines,
> which were:
>
> drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (struct bcm_connect_mgr_params *) ntohl(
> ^
> drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (struct bcm_connect_mgr_params *) ntohl(
> ^
> drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (struct bcm_connect_mgr_params *) ntohl(
>
> This resolves the issue by generating 64bit friendly code.
>
As far as I can tell this isn't a bugfix, it just hides a real 64 bit
bug. Let's leave the bug how it is so it's easy to see from a long way
away.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-15 12:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 12:26 [PATCH] bcm/CmHost.c: Fix noisy compile warnings Jeff Kirsher
2014-10-15 12:33 ` Joe Perches
2014-10-15 12:34 ` Dan Carpenter [this message]
2014-10-15 12:59 ` Dan Carpenter
2014-10-15 13:03 ` Jeff Kirsher
2014-10-15 16:11 ` Joe Perches
2014-10-15 17:42 ` Jeff Kirsher
2014-10-15 18:24 ` Fabio Estevam
2014-10-15 18:54 ` Jeff Kirsher
2014-10-15 18:56 ` Joe Perches
2014-10-15 18:56 ` Fabio Estevam
2014-10-15 19:53 ` Dan Carpenter
2014-10-15 20:03 ` Joe Perches
2014-10-16 7:48 ` Dan Carpenter
2014-10-16 7:54 ` Jeff Kirsher
2014-10-15 21:41 ` Matthias Beyer
2014-10-15 22:19 ` Jeff Kirsher
2014-10-15 22:24 ` Matthias Beyer
2014-10-15 22:41 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015123431.GA23154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox